Page MenuHomeFreeBSD
Differential D32162

libpmc: add some AMD pmu counter aliases
ClosedPublic
Actions

Authored by mhorne on Sep 27 2021, 7:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 21, 5:01 AM
Unknown Object (File)
Mon, Oct 20, 1:37 AM
Unknown Object (File)
Fri, Oct 17, 2:48 AM
Unknown Object (File)
Fri, Oct 17, 2:48 AM
Unknown Object (File)
Fri, Oct 17, 2:48 AM
Unknown Object (File)
Fri, Oct 17, 2:48 AM
Unknown Object (File)
Thu, Oct 16, 5:49 PM
Unknown Object (File)
Mon, Oct 13, 5:19 PM
View All Files
Subscribers
imp

Details

Reviewers
emaste
Group Reviewers
pmc
Commits
rG3c01f7415067: libpmc: add some AMD pmu counter aliases
rGa20c10893eb1: libpmc: add some AMD pmu counter aliases
Summary

Make it mostly compatible with what's defined for Intel. Except where
noted, these are defined for all of amdzen(1|2|3).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 41786
Build 38675: arc lint + arc unit

Event Timeline

mhorne created this revision.Sep 27 2021, 7:48 PM
Herald added a subscriber: imp. · View Herald TranscriptSep 27 2021, 7:48 PM
mhorne requested review of this revision.Sep 27 2021, 7:48 PM
Harbormaster completed remote builds in B41786: Diff 95793.Sep 27 2021, 7:48 PM
emaste added inline comments.Sep 27 2021, 7:57 PM
lib/libpmc/libpmc_pmu_util.c
98

where does this one come from?

mhorne added inline comments.Sep 28 2021, 1:37 PM
lib/libpmc/libpmc_pmu_util.c
98

It is meant to invoke the pmc.tsc(3) class, which has exactly one event that reads the TSC. I copied it from the Intel aliases above, but looking at it now, this doesn't actually work...

I will move this alias out of this file to a more appropriate place.

mhorne updated this revision to Diff 95856.Sep 28 2021, 2:05 PM

Drop non-functional 'cycles' alias in favor of D32197.

Harbormaster completed remote builds in B41812: Diff 95856.Sep 28 2021, 2:05 PM
emaste accepted this revision.Sep 28 2021, 3:07 PM
This revision is now accepted and ready to land.Sep 28 2021, 3:07 PM
Closed by commit rGa20c10893eb1: libpmc: add some AMD pmu counter aliases (authored by mhorne). · Explain WhySep 30 2021, 2:17 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rGa20c10893eb1: libpmc: add some AMD pmu counter aliases.
mhorne added a commit: rG3c01f7415067: libpmc: add some AMD pmu counter aliases.Oct 15 2021, 3:27 PM

Revision Contents
Changeset List

PathSize
lib/
libpmc/
14 lines

Diff 95793

View Options

lib/libpmc/libpmc_pmu_util.c

Loading...