Page MenuHomeFreeBSD
Differential D32096

graphics/jpeg-turbo: Disable SIMD instructions on ARMv6 platforms
ClosedPublic
Actions

Authored by diizzy on Sep 24 2021, 5:23 AM.
Tags
None
Referenced Files
F167703833: D32096.id95608.diff
Sun, Aug 23, 9:16 PM
F167688109: D32096.id95681.diff
Sun, Aug 23, 7:08 PM
F167677426: D32096.id95608.diff
Sun, Aug 23, 5:32 PM
F167677422: D32096.diff
Sun, Aug 23, 5:32 PM
F167677307: D32096.id95681.diff
Sun, Aug 23, 5:31 PM
Unknown Object (File)
Sat, Aug 22, 1:27 PM
Unknown Object (File)
Tue, Aug 11, 3:05 PM
Unknown Object (File)
Thu, Jul 30, 6:29 PM
View All Files
Subscribers
antoine

Details

Reviewers
tcberner
arrowd
lbartoletti
antoine
Group Reviewers
portmgr
Commits
R11:6b077d7a7d13: graphics/jpeg-turbo: Disable SIMD instructions on ARMv6 platforms
Summary

jpeg-turbo incorrectly assumes that SIMD instructions are available on all ARM platforms
PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=258685

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

diizzy requested review of this revision.Sep 24 2021, 5:23 AM
diizzy created this revision.
antoine accepted this revision.Sep 24 2021, 7:22 AM
antoine added a subscriber: antoine.

Looks fine.
Could you open a bug upstream to find a correct solution too? (SIMD used to build fine on armv6)

This revision is now accepted and ready to land.Sep 24 2021, 7:22 AM
Closed by commit R11:6b077d7a7d13: graphics/jpeg-turbo: Disable SIMD instructions on ARMv6 platforms (authored by diizzy). · Explain WhySep 24 2021, 9:11 PM
This revision was automatically updated to reflect the committed changes.
diizzy added a commit: R11:6b077d7a7d13: graphics/jpeg-turbo: Disable SIMD instructions on ARMv6 platforms.
diizzy added a comment.Sep 25 2021, 2:49 PM

@antoine
SIMD (NEON) is unsupported on ARMv6 according to mikael@ so I don't think there's much to do?

antoine added a comment.Sep 25 2021, 7:03 PM
In D32096#725319, @diizzy wrote:

@antoine
SIMD (NEON) is unsupported on ARMv6 according to mikael@ so I don't think there's much to do?

In this case, the build system should automatically detect that it is not supported.

Revision Contents
Changeset List

PathSize
graphics/
jpeg-turbo/
6 lines

Diff 95681

View Options

graphics/jpeg-turbo/Makefile

Loading...