Differential D32064

read.cc: fix build on powerpc
ClosedPublic
Actions

Authored by kib on Sep 22 2021, 10:51 PM.

Details

Reviewers

Commits

rG3fcbde5e883a: tests/sys/fs/fusefs/read.cc: fix build on powerpc64

Summary

There sig_atomic_t is shorter than void * (we had similar ABI bug on amd64).
As result, it cannot keep pointer.

Assigning to void * is actually safe for us in a signal handler.

Fixes:  4f917847c9037d

See https://ci.freebsd.org/job/FreeBSD-main-powerpc64le-build/3287/consoleFull

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib requested review of this revision.Sep 22 2021, 10:51 PM

kib created this revision.

Powerpc64 has a sig_atomic_t shorter than a pointer? ughh. Does that mean that it doesn't have any 64-bit atomic types?

This revision is now accepted and ready to land.Sep 22 2021, 11:06 PM

In D32064#723609, @asomers wrote:

Powerpc64 has a sig_atomic_t shorter than a pointer? ughh. Does that mean that it doesn't have any 64-bit atomic types?

PPC64 has full set of 64bit atomics. It is just FreeBSD' ABI bug that sig_atomic_t is int. See sys/powerpc/include/signal.h. It was not adjusted for 64bit port.

Closed by commit rG3fcbde5e883a: tests/sys/fs/fusefs/read.cc: fix build on powerpc64 (authored by kib). · Explain WhySep 23 2021, 12:52 AM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG3fcbde5e883a: tests/sys/fs/fusefs/read.cc: fix build on powerpc64.