Differential D31998

buffer pager: allow get_blksize method to return error
ClosedPublic
Actions

Authored by kib on Sep 16 2021, 11:58 PM.

Details

Reviewers

asomers

Commits

rG197a4f29f39e: buffer pager: allow get_blksize method to return error

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib requested review of this revision.Sep 16 2021, 11:58 PM

kib created this revision.

kib mentioned this in D31994: fusefs: don't panic if FUSE_GETATTR fails durint VOP_GETPAGES.

Why are you changing the blksz from an int to a long? The commit message doesn't mention that.

In D31998#721831, @asomers wrote:

Why are you changing the blksz from an int to a long? The commit message doesn't mention that.

Either bsize should be changed to int, or bo_bs to long. It is clear from the code, I decided not to explain trivial things. I (randomly) preferred bsize, since it is passed to other API place.

The change looks fine. But the commit message is incomplete, because it doesn't mention removing the panic in fuse. Should I merge this change into D31994 ?

In D31998#722022, @asomers wrote:

The change looks fine. But the commit message is incomplete, because it doesn't mention removing the panic in fuse. Should I merge this change into D31994 ?

If you want to keep fusefs fix for youself, I can drop it there, only modifying fusefs pager vop to return 0 as error. Is this fine with you?

Drop part of fusefs patch, remove removal of the kassert and returning error.

Yes, I think that makes more sense.

This revision is now accepted and ready to land.Sep 17 2021, 4:52 PM

Closed by commit rG197a4f29f39e: buffer pager: allow get_blksize method to return error (authored by kib). · Explain WhySep 17 2021, 5:44 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG197a4f29f39e: buffer pager: allow get_blksize method to return error.

asomers mentioned this in rGc858f3d89b3c: fusefs: don't panic if FUSE_GETATTR fails durint VOP_GETPAGES.Oct 7 2021, 8:01 PM