Fix tablegen iconv(3) test utility on arm64.
ClosedPublic
Actions

Authored by trasz on Sep 3 2021, 8:19 AM.

Tags

None

Referenced Files

	F161383231: D31817.id94734.diff
	Fri, Jul 3, 7:29 AM

	F161340979: D31817.id94607.diff
	Thu, Jul 2, 11:44 PM

	F161337201: D31817.id.diff
	Thu, Jul 2, 10:56 PM

	Unknown Object (File)
	Tue, Jun 30, 9:00 PM

	Unknown Object (File)
	Tue, Jun 16, 7:36 PM

	Unknown Object (File)
	Tue, Jun 16, 3:16 PM

	Unknown Object (File)
	Mon, Jun 8, 10:56 PM

	Unknown Object (File)
	May 17 2026, 10:50 PM

View All Files

Subscribers

imp

Details

Reviewers

allanjude

Commits

rG0016b7da3441: iconv: Fix tablegen iconv test utility on arm64

Summary

Previously it would loop indefinitely on getopt_long(3)
due to 'char' being unsigned.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trasz created this revision.Sep 3 2021, 8:19 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 3 2021, 8:19 AM

trasz requested review of this revision.Sep 3 2021, 8:19 AM

Harbormaster completed remote builds in B41348: Diff 94607.Sep 3 2021, 8:20 AM

allanjude accepted this revision.Sep 3 2021, 8:24 PM

This revision is now accepted and ready to land.Sep 3 2021, 8:24 PM

Closed by commit rG0016b7da3441: iconv: Fix tablegen iconv test utility on arm64 (authored by trasz). · Explain WhySep 6 2021, 2:46 PM

This revision was automatically updated to reflect the committed changes.

trasz added a commit: rG0016b7da3441: iconv: Fix tablegen iconv test utility on arm64.

Revision Contents
Changeset List

Path

Size

tools/

test/

iconv/

tablegen/

tablegen.c

2 lines

Diff 94734

View Options

tools/test/iconv/tablegen/tablegen.c

Fix tablegen iconv(3) test utility on arm64.ClosedPublicActions