Differential D31653

wsp(4): Add evdev support.
ClosedPublic
Actions

Authored by wulf on Aug 24 2021, 1:02 AM.

Tags

None

Referenced Files

	F153352275: D31653.id94149.diff
	Mon, Apr 20, 4:02 PM

	F153352200: D31653.id94149.diff
	Mon, Apr 20, 4:02 PM

	F153262795: D31653.id94149.diff
	Mon, Apr 20, 3:19 AM

	Unknown Object (File)
	Fri, Apr 17, 9:35 AM

	Unknown Object (File)
	Wed, Apr 15, 8:43 PM

	Unknown Object (File)
	Tue, Apr 14, 7:16 PM

	Unknown Object (File)
	Tue, Apr 14, 2:13 PM

	Unknown Object (File)
	Tue, Apr 14, 1:00 PM

Subscribers

Details

Reviewers

Commits

rG139144a7ae7c: wsp(4): Add evdev support.
rG8d73071c47ff: wsp(4): Add evdev support.

Summary

Although patch is rather big, it mostly consists of multitouch code
refactoring required to import EBM-solver implementation from OpenBSD
and of EBM-solver itself which is required for touch tracking.

"Touch tracking is a process of assignment of unique trackingID to each
initiated contact on the surface. Keeping the trackingIDs persistent
across multitouch reports requires solving of so called Euclidian
Bipartite Matching problem."

Tested by Greg V, Constantin Furst<constantin_AT_fuersten_DOT_info>
MFC after 2 weeks
PR 252236

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 41176
Build 38065: arc lint + arc unit

Event Timeline

wulf created this revision.Aug 24 2021, 1:02 AM

Herald added a subscriber: imp. · View Herald TranscriptAug 24 2021, 1:02 AM

wulf requested review of this revision.Aug 24 2021, 1:02 AM

Harbormaster completed remote builds in B41175: Diff 94089.Aug 24 2021, 1:02 AM

s/convertor/converter/

Harbormaster completed remote builds in B41176: Diff 94091.Aug 24 2021, 7:58 AM

• hselasky added inline comments.Aug 24 2021, 8:13 AM

sys/dev/evdev/evdev.h
167	s/__inline/inline __inline is only used if you need to compile the code without inline.
sys/dev/usb/input/wsp.c
215	name this structure "wsp_tp"

s/__inline/inline/
Change both structure and global variable names from tp to wsp_tp

Harbormaster completed remote builds in B41178: Diff 94097.Aug 24 2021, 1:13 PM

Looks good for USB's point of view.

This revision is now accepted and ready to land.Aug 24 2021, 1:57 PM

Closed by commit rG8d73071c47ff: wsp(4): Add evdev support. (authored by wulf). · Explain WhyAug 24 2021, 11:05 PM

This revision was automatically updated to reflect the committed changes.

wulf added a commit: rG8d73071c47ff: wsp(4): Add evdev support..

wulf added a commit: rG139144a7ae7c: wsp(4): Add evdev support..Sep 8 2021, 12:03 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

evdev/

2 lines

41 lines

49 lines

666 lines

evdev_private.h

14 lines

41 lines

1 line

usb/

input/

4 lines

605 lines

modules/

usb/

wsp/

4 lines

Diff 94091

sys/dev/evdev/cdev.c

Loading...

sys/dev/evdev/evdev.h

Loading...

sys/dev/evdev/evdev.c

Loading...

sys/dev/evdev/evdev_mt.c

Loading...

sys/dev/evdev/evdev_private.h

Loading...

sys/dev/evdev/evdev_utils.c

Loading...

sys/dev/evdev/uinput.c

Loading...

sys/dev/usb/input/atp.c

Loading...

sys/dev/usb/input/wsp.c

Loading...

sys/modules/usb/wsp/Makefile

Loading...