Page MenuHomeFreeBSD
Differential D31398

hid: move proper hat switch handling from ps4dshock to hgame
ClosedPublic
Actions

Authored by val_packett.cool on Aug 3 2021, 4:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 26, 7:11 PM
Unknown Object (File)
Fri, Jun 26, 7:51 AM
Unknown Object (File)
Sun, Jun 21, 9:38 PM
Unknown Object (File)
Sat, Jun 20, 9:43 AM
Unknown Object (File)
Sat, Jun 13, 12:58 AM
Unknown Object (File)
Fri, Jun 5, 11:01 PM
Unknown Object (File)
Fri, Jun 5, 8:04 PM
Unknown Object (File)
May 30 2026, 2:58 PM
View All Files
Subscribers
imp
Contributor Reviews (src)

Details

Reviewers
wulf
Group Reviewers
Contributor Reviews (src)
Commits
rG51b221611454: hid: move proper hat switch handling from ps4dshock to hgame
Summary

Generic "DirectInput" HID gamepads need this handling too.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 40833
Build 37722: arc lint + arc unit

Event Timeline

val_packett.cool created this revision.Aug 3 2021, 4:42 PM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptAug 3 2021, 4:42 PM
val_packett.cool requested review of this revision.Aug 3 2021, 4:42 PM
Harbormaster completed remote builds in B40833: Diff 93184.Aug 3 2021, 4:42 PM
val_packett.cool added reviewers: wulf, Contributor Reviews (src).Aug 3 2021, 4:43 PM
wulf accepted this revision.Aug 3 2021, 10:15 PM

Which devices it was tested on?

I found out that WebHID wants to do the same thing https://github.com/w3c/gamepad/issues/56 but did not find any docs describing HAT_SWITCH usage in DirectInput mode.

This revision is now accepted and ready to land.Aug 3 2021, 10:15 PM
val_packett.cool added a comment.Aug 3 2021, 11:49 PM

Tested on a no-name cheap gamepad that literally says "acme" on it, confirmed to match Linux behavior.

Closed by commit rG51b221611454: hid: move proper hat switch handling from ps4dshock to hgame (authored by val_packett.cool, committed by wulf). · Explain WhyAug 16 2021, 9:03 PM
This revision was automatically updated to reflect the committed changes.
wulf added a commit: rG51b221611454: hid: move proper hat switch handling from ps4dshock to hgame.

Revision Contents
Changeset List

PathSize
sys/
dev/
hid/
1 line
34 lines
35 lines

Diff 93184

View Options

sys/dev/hid/hgame.h

Loading...
View Options

sys/dev/hid/hgame.c

Loading...
View Options

sys/dev/hid/ps4dshock.c

Loading...