Differential D31265

Escape any '.' characters in sysctl node names
ClosedPublic
Actions

Authored by asomers on Jul 21 2021, 9:15 PM.

Tags

None

Referenced Files

	F122019196: D31265.id92627.diff
	Tue, Jul 1, 12:24 PM

	Unknown Object (File)
	Mon, Jun 30, 1:02 PM

	Unknown Object (File)
	Mon, Jun 30, 7:52 AM

	Unknown Object (File)
	Sat, Jun 28, 6:32 PM

	Unknown Object (File)
	Fri, Jun 27, 9:37 AM

	Unknown Object (File)
	Thu, Jun 26, 6:29 AM

	Unknown Object (File)
	Fri, Jun 20, 3:20 AM

	Unknown Object (File)
	Tue, Jun 17, 2:44 AM

Subscribers

martin_lispworks.com

Details

Reviewers

Commits

rG98c467192082: Escape any '.' characters in sysctl node names
rGe7d99efb3638: Escape any '.' characters in sysctl node names
rG6c9506559080: Escape any '.' characters in sysctl node names

Summary

ZFS creates some sysctl nodes that include a pool name, and '.' is an
allowed character in pool names. But it's the separator in the sysctl
tree, so it can't be included in a sysctl name. Replace it with "%25".
Handily, "%" is illegal in ZFS pool names, so there's no ambiguity
there.

PR: 257316
MFC after: 3 weeks
Sponsored by: Axcient

Test Plan

manually tested

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers created this revision.Jul 21 2021, 9:15 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 21 2021, 9:15 PM

asomers requested review of this revision.Jul 21 2021, 9:15 PM

Harbormaster completed remote builds in B40613: Diff 92608.Jul 21 2021, 9:15 PM

martin_lispworks.com added a subscriber: martin_lispworks.com.Jul 22 2021, 10:17 AM

martin_lispworks.com added inline comments.

sys/kern/kern_sysctl.c
771	Is this 1 byte too short (no space for the nul)?

asomers added inline comments.Jul 22 2021, 12:52 PM

sys/kern/kern_sysctl.c
771	Yep.

Allow space for the trailing NUL

Harbormaster completed remote builds in B40622: Diff 92627.Jul 22 2021, 12:54 PM

Seems reasonable to me.

sys/kern/kern_sysctl.c
765	Accumulating len is unnecessary since it's just i + 1, which you could do once outside of the loop.

This revision is now accepted and ready to land.Jul 22 2021, 3:57 PM

Closed by commit rG6c9506559080: Escape any '.' characters in sysctl node names (authored by asomers). · Explain WhyJul 22 2021, 4:24 PM

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rG6c9506559080: Escape any '.' characters in sysctl node names.

asomers added a commit: rGe7d99efb3638: Escape any '.' characters in sysctl node names.Aug 22 2021, 9:23 PM

asomers added a commit: rG98c467192082: Escape any '.' characters in sysctl node names.Aug 22 2021, 11:03 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

48 lines

Diff 92641

sys/kern/kern_sysctl.c

Loading...