Differential D31228

Update mlx5en(4)
ClosedPublic
Actions

Authored by • hselasky on Jul 20 2021, 9:59 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Sep 11, 8:13 PM

	Unknown Object (File)
	Thu, Sep 10, 9:23 PM

	Unknown Object (File)
	Wed, Sep 9, 10:41 PM

	Unknown Object (File)
	Tue, Sep 8, 8:29 PM

	Unknown Object (File)
	Sun, Sep 6, 2:26 PM

	Unknown Object (File)
	Sun, Sep 6, 10:59 AM

	Unknown Object (File)
	Sun, Sep 6, 9:26 AM

	Unknown Object (File)
	Sun, Sep 6, 2:17 AM

Subscribers

None

Details

Reviewers

kib
menyy_mellanox.com

Commits

rGc203dfe17bc8: Update the mlx5en(4) manual page.
rG575945f10b9e: Update the mlx5en(4) manual page.

Summary

Sponsored by: NVIDIA Networking

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

• hselasky requested review of this revision.Jul 20 2021, 9:59 AM

• hselasky created this revision.

kib added inline comments.Jul 20 2021, 11:32 AM

share/man/man4/mlx5en.4
79	Is this right URL?
103	.Dv dev.mce.<N> .
106	persistent?
109–110	Nvidia networking?
110–111	Is it right URL?
123	I think a reference to 10.0 is too late. The note about 'first appeared' cannot be changed by retrospective MFC, so keep it as is.
128	Is this right email?

• hselasky marked 7 inline comments as done.Jul 20 2021, 3:56 PM

• hselasky added inline comments.

share/man/man4/mlx5en.4
79	Yes, I see no other yet.
109–110	NVIDIA Mellanox networking. Mellanox is still a brand from what I know.
110–111	Yes, for now.

Address comments from @kib

kib added inline comments.Jul 20 2021, 4:30 PM

share/man/man4/mlx5en.4
70
75	.Dv mce<N> not sure if some minimal elaboration of the meaning of <N> is useful. Also, the most puzzling part for a newby is to understand that PCI attachment names the device mlx_core<N>.

• hselasky marked 2 inline comments as done.Jul 21 2021, 8:50 AM

Address comments from kib@

kib accepted this revision.Jul 21 2021, 9:01 AM

This revision is now accepted and ready to land.Jul 21 2021, 9:01 AM

Closed by commit rG575945f10b9e: Update the mlx5en(4) manual page. (authored by • hselasky). · Explain WhyJul 21 2021, 9:12 AM

This revision was automatically updated to reflect the committed changes.

• hselasky added a commit: rG575945f10b9e: Update the mlx5en(4) manual page..

• hselasky added a commit: rGc203dfe17bc8: Update the mlx5en(4) manual page..Sep 22 2021, 1:03 PM

Revision Contents
Changeset List

Path

Size

share/

man/

man4/

84 lines

Diff 92503

share/man/man4/mlx5en.4

Loading...