Page MenuHomeFreeBSD

stand/kmem_zalloc: panic when a M_WAITOK allocation fails
ClosedPublic

Authored by imp on Jul 8 2021, 5:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 21 2024, 6:42 AM
Unknown Object (File)
Feb 8 2024, 11:27 PM
Unknown Object (File)
Dec 23 2023, 3:11 AM
Unknown Object (File)
Dec 18 2023, 3:09 AM
Unknown Object (File)
Dec 14 2023, 10:19 PM
Unknown Object (File)
Nov 23 2023, 1:10 PM
Unknown Object (File)
Oct 26 2023, 4:33 PM
Unknown Object (File)
Oct 20 2023, 7:47 AM
Subscribers
None

Details

Summary

Malloc() might return NULL, in which case we will panic with a NULL
pointer deref. Make it panic when the allocation fails to preserve the
postcondtion that we never return a non-NULL value.

PR: 249859
Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Jul 8 2021, 5:41 AM
imp created this revision.
imp added inline comments.
sys/sys/malloc.h
322

This crept in because we never were testing flags before.

sys/sys/malloc.h
308

Shouldn't this order be reversed? or maybe create inline [function] instead? just thinking...

sys/sys/malloc.h
308

Order of what?
It can't be an inline function because I want FILE and LINE and I didn't see a good way to get that with an inline function.

309

This should be if (p == 0 && (flags & M_WAITOK) != 0)

update and make sure p == NULL before panicing.

Seems good, thanks!

sys/sys/malloc.h
308

Order of what?
It can't be an inline function because I want FILE and LINE and I didn't see a good way to get that with an inline function.

This revision is now accepted and ready to land.Jul 9 2021, 6:40 AM