Page MenuHomeFreeBSD

Fix pmbr issues > 2TB
ClosedPublic

Authored by imp on Jul 7 2021, 9:37 PM.
Tags
None
Referenced Files
F133023385: D31100.id91953.diff
Wed, Oct 22, 4:13 AM
Unknown Object (File)
Mon, Oct 20, 2:44 PM
Unknown Object (File)
Wed, Oct 15, 5:18 PM
Unknown Object (File)
Wed, Oct 15, 5:18 PM
Unknown Object (File)
Wed, Oct 15, 5:18 PM
Unknown Object (File)
Wed, Oct 15, 5:18 PM
Unknown Object (File)
Wed, Oct 15, 6:39 AM
Unknown Object (File)
Wed, Oct 15, 6:17 AM
Subscribers

Details

Summary

These issues have low impact because they require precise circumstances
to trigger one of them. The disk must be > 2 TiB in size and either:

  • The primary GPT header is dammaged.
  • The freebsd-boot partiton is located farther than the first 2 TiB of the disc and one of its sectors takes place at a lba value that makes the higher 32 bits of this very value change.

Errors and corrections folow:

  • decl and incl don't affect CF, so replace with subl/addl $1
  • repe uses %cx, so move size to it with movw
  • moving a 64-bit value with %cx of 2 (should be 4) so addresses > 2TB will work.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 40385
Build 37274: arc lint + arc unit