Page MenuHomeFreeBSD
Differential D30879

cam: Remove CAM_TRUE and CAM_FALSE, they are unused and duplicate bool
ClosedPublic
Actions

Authored by imp on Jun 23 2021, 8:37 PM.
Tags
None
Referenced Files
F132385975: D30879.id.diff
Thu, Oct 16, 11:18 AM
F132385966: D30879.id91475.diff
Thu, Oct 16, 11:18 AM
F132385963: D30879.id91277.diff
Thu, Oct 16, 11:18 AM
Unknown Object (File)
Wed, Oct 15, 11:39 PM
Unknown Object (File)
Mon, Sep 29, 4:56 AM
Unknown Object (File)
Sat, Sep 20, 12:53 PM
Unknown Object (File)
Wed, Sep 17, 8:05 AM
Unknown Object (File)
Sep 17 2025, 12:23 AM
View All 91 Files
Subscribers
scottl

Details

Reviewers
scottl
Group Reviewers
cam
Commits
rG2b0987023804: cam: Remove CAM_TRUE and CAM_FALSE, they are unused and duplicate bool
Summary

These were in the original CAM commit in 3.x, but were not used there,
nor have they been used since then that I can tell.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 40064
Build 36953: arc lint + arc unit

Event Timeline

imp created this revision.Jun 23 2021, 8:37 PM
Herald added a reviewer: cam. · View Herald TranscriptJun 23 2021, 8:37 PM
imp requested review of this revision.Jun 23 2021, 8:37 PM
Harbormaster completed remote builds in B40064: Diff 91277.Jun 23 2021, 8:37 PM
imp edited the summary of this revision. (Show Details)Jun 23 2021, 8:38 PM
imp edited the summary of this revision. (Show Details)Jun 23 2021, 8:42 PM
scottl accepted this revision.Jun 24 2021, 1:31 AM
scottl added a subscriber: scottl.

Part of me feels that abstracted definitions for implementation semantics is good API design, but it sounds like this is a good candidate for garbage collection.

This revision is now accepted and ready to land.Jun 24 2021, 1:31 AM
imp added a comment.Jun 24 2021, 3:33 AM
In D30879#694645, @scottl wrote:

Part of me feels that abstracted definitions for implementation semantics is good API design, but it sounds like this is a good candidate for garbage collection.

Had they been in use, I'd likely not have bothered to try to eliminate them as is the trend elsewhere for other non-standard bools... But since they were unused for 23 years, I rather suspected they weren't in line for use any time soon.

imp added a child revision: D30884: cam: change xpt_clone_path to return int.Jun 24 2021, 10:39 PM
Closed by commit rG2b0987023804: cam: Remove CAM_TRUE and CAM_FALSE, they are unused and duplicate bool (authored by imp). · Explain WhyJun 28 2021, 10:26 PM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG2b0987023804: cam: Remove CAM_TRUE and CAM_FALSE, they are unused and duplicate bool.

Revision Contents
Changeset List

PathSize
sys/
cam/
3 lines

Diff 91277

View Options

sys/cam/cam_ccb.h

Loading...