Page MenuHomeFreeBSD

add gone_in.9
ClosedPublic

Authored by emaste on Jun 9 2021, 5:24 PM.
Tags
None
Referenced Files
F103367099: D30703.id.diff
Sun, Nov 24, 3:02 AM
Unknown Object (File)
Fri, Nov 8, 10:20 PM
Unknown Object (File)
Fri, Nov 8, 10:03 PM
Unknown Object (File)
Fri, Nov 8, 9:58 PM
Unknown Object (File)
Oct 22 2024, 6:57 PM
Unknown Object (File)
Oct 18 2024, 10:02 AM
Unknown Object (File)
Oct 3 2024, 2:44 AM
Unknown Object (File)
Oct 2 2024, 11:34 PM
Subscribers

Details

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste requested review of this revision.Jun 9 2021, 5:24 PM
emaste updated this revision to Diff 90644.
emaste created this revision.

upload right version

share/man/man9/gone_in.9
76

11.x ABI compat isn't the headlining reason to retire, necessarily.
In the past this has been more like "Giant locked filesystem" or "Driver not migrated from old API" or simiar

79

int

83

This message needs to be more along the lines of "This hardware no longer relevant to FreeBSD" or "This wifi driver doesn't support FooBar crypto" or some other minimum bar.

90

11

share/man/man9/gone_in.9
76

This was copied from an in-tree one, but indeed "Giant locked filesystem" is probably a good canonical example

83

Here's some examples from the tree, as they'd appear in dmesg:

Deprecated code (to be removed in FreeBSD 13): pccard removed, an doesn't support modern crypto
Deprecated code (to be removed in FreeBSD 13): pccard removed, an doesn't support modern crypto
Deprecated code (to be removed in FreeBSD 13): amr(4) driver
Deprecated code (to be removed in FreeBSD 13): FreeBSD 11.x ABI compat
Deprecated code (to be removed in FreeBSD 14): FreeBSD 12.x ABI compat
Deprecated code (to be removed in FreeBSD 13): drm2 drivers
Deprecated code (to be removed in FreeBSD 14): esp(4) driver
Deprecated code (to be removed in FreeBSD 14): PC Card to be removed
Deprecated code (to be removed in FreeBSD 14): mly(4) removed
prefixed with the device name/number for gone_in_dev of course

IMO something short like "ISA drivers", "obsolete hardware" etc. is what we should suggest

sys/dev/mly/mly.c
339: gone_in_dev(dev, 13, "");

sys/dev/twa/tw_osl_freebsd.c
416: gone_in_dev(dev, 13, "twa(4) removed");

sys/dev/iir/iir_pci.c
339: gone_in_dev(dev, 13, "iir(4) removed");

Just some minor nits.

share/man/man9/gone_in.9
53
60
  • convert one FreeBSD to .Fx (from debdrup)
  • add Ns to avoid space before )
emaste added inline comments.
share/man/man9/gone_in.9
60

I think this one probably should not change because it's literal console output.

62

Added Ns here

This revision is now accepted and ready to land.Aug 16 2021, 9:14 PM
This revision now requires review to proceed.Aug 16 2021, 9:17 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 16 2021, 9:24 PM
This revision was automatically updated to reflect the committed changes.