Page MenuHomeFreeBSD
Differential D30690

Split kern_poll() on two counterparts.
ClosedPublic
Actions

Authored by dchagin on Jun 8 2021, 6:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 3, 8:37 PM
Unknown Object (File)
May 12 2024, 8:06 PM
Unknown Object (File)
May 8 2024, 10:39 PM
Unknown Object (File)
May 8 2024, 10:35 PM
Unknown Object (File)
May 8 2024, 10:35 PM
Unknown Object (File)
May 8 2024, 10:35 PM
Unknown Object (File)
May 7 2024, 10:18 PM
Unknown Object (File)
May 5 2024, 9:28 PM
View All 50 Files
Subscribers
imp

Details

Reviewers
kib
Group Reviewers
Linux Emulation
Commits
rG3ae9b75f6bad: Split kern_poll() on two counterparts.
rGe884512ad143: Split kern_poll() on two counterparts.
Summary

The kern_poll() operates on clear kernel data, while the kern_poll_ufds()
operates on user supplied pollfd.
Move nfds check to kern_poll_maxfds().

No functional changes, it's for future use in the Linux emulation layer.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 39787
Build 36676: arc lint + arc unit

Event Timeline

dchagin created this revision.Jun 8 2021, 6:35 AM
Herald added a subscriber: imp. · View Herald TranscriptJun 8 2021, 6:35 AM
dchagin requested review of this revision.Jun 8 2021, 6:35 AM
Harbormaster completed remote builds in B39787: Diff 90558.Jun 8 2021, 6:35 AM
dchagin added reviewers: Linux Emulation, kib.Jun 8 2021, 6:36 AM
dchagin changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.
dchagin updated this revision to Diff 90574.Jun 8 2021, 11:26 AM

make kern_poll private, kern_poll_ufds - public
use kern_poll_ufds in freebsd32, linux

Harbormaster completed remote builds in B39795: Diff 90574.Jun 8 2021, 11:26 AM
dchagin updated this revision to Diff 90578.Jun 8 2021, 12:23 PM

export both methods

Harbormaster completed remote builds in B39798: Diff 90578.Jun 8 2021, 12:23 PM
kib added a comment.Jun 8 2021, 2:01 PM

I believe it would be useful to add a comment above each of kern_poll_{u,k}fds, explaining that corresponding function expects from fds pointer.

sys/kern/sys_generic.c
1532

I would make kern_poll_maxfds() returning bool, and then just write

if (!kern_poll_maxfds(nfds))
    return (EINVAL);
dchagin updated this revision to Diff 90596.Jun 8 2021, 5:18 PM

fixed

Harbormaster completed remote builds in B39808: Diff 90596.Jun 8 2021, 5:18 PM
dchagin marked an inline comment as done.Jun 8 2021, 5:21 PM

I left the previous name for the kern_poll() to not break third-party modules

kib added inline comments.Jun 8 2021, 7:10 PM
sys/kern/sys_generic.c
1424

I do not see much sense in the second sentence.

dchagin updated this revision to Diff 90603.Jun 8 2021, 7:43 PM

fix comment

Harbormaster completed remote builds in B39810: Diff 90603.Jun 8 2021, 7:43 PM
kib accepted this revision.Jun 8 2021, 8:11 PM
This revision is now accepted and ready to land.Jun 8 2021, 8:11 PM
Closed by commit rGe884512ad143: Split kern_poll() on two counterparts. (authored by dchagin). · Explain WhyJun 10 2021, 12:13 PM
This revision was automatically updated to reflect the committed changes.
dchagin added a commit: rGe884512ad143: Split kern_poll() on two counterparts..
dchagin added a commit: rG3ae9b75f6bad: Split kern_poll() on two counterparts..Jun 17 2022, 7:32 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
87 lines
sys/
1 line

Diff 90558

View Options

sys/kern/sys_generic.c

Loading...
View Options

sys/sys/syscallsubr.h

Loading...