ffs: Correct the input size check in sysctl_ffs_fsck()
ClosedPublic
Actions

Authored by markj on May 31 2021, 7:05 PM.

Tags

None

Referenced Files

	F171497906: D30586.id90221.diff
	Fri, Sep 11, 11:52 AM

	F171478123: D30586.id90221.diff
	Fri, Sep 11, 8:39 AM

	Unknown Object (File)
	Wed, Sep 9, 3:36 PM

	Unknown Object (File)
	Wed, Sep 9, 12:07 PM

	Unknown Object (File)
	Wed, Sep 9, 12:07 PM

	Unknown Object (File)
	Tue, Sep 8, 8:37 PM

	Unknown Object (File)
	Sat, Sep 5, 10:55 PM

	Unknown Object (File)
	Sat, Sep 5, 9:57 AM

View All Files

Subscribers

imp

Details

Reviewers

mckusick

Commits

rGb2f9575646f8: ffs: Correct the input size check in sysctl_ffs_fsck()

Summary

Make sure we return an error if no input was specified, or if it is
shorter than the size of the command structure.

Reported by: KMSAN
MFC after: 1 week

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 39609
Build 36498: arc lint + arc unit

Event Timeline

markj created this revision.May 31 2021, 7:05 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 31 2021, 7:05 PM

markj requested review of this revision.May 31 2021, 7:05 PM

Harbormaster completed remote builds in B39609: Diff 90200.May 31 2021, 7:05 PM

Good catch, definitely needed.

This revision is now accepted and ready to land.May 31 2021, 10:53 PM

Closed by commit rGb2f9575646f8: ffs: Correct the input size check in sysctl_ffs_fsck() (authored by markj). · Explain WhyMay 31 2021, 11:10 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGb2f9575646f8: ffs: Correct the input size check in sysctl_ffs_fsck().

Revision Contents
Changeset List

Path

Size

sys/

ufs/

ffs/

ffs_alloc.c

4 lines

Diff 90200

View Options

ffs: Correct the input size check in sysctl_ffs_fsck()ClosedPublicActions