axgbe: Don't dereference NULL pointers
ClosedPublic
Actions

Authored by imp on May 21 2021, 4:51 AM.

Tags

None

Referenced Files

	F168490673: D30373.diff
	Fri, Aug 28, 4:08 PM

	Unknown Object (File)
	Thu, Aug 27, 4:42 PM

	Unknown Object (File)
	Thu, Aug 27, 12:43 PM

	Unknown Object (File)
	Tue, Aug 25, 3:32 PM

	Unknown Object (File)
	Tue, Aug 25, 11:44 AM

	Unknown Object (File)
	Tue, Aug 25, 11:07 AM

	Unknown Object (File)
	Tue, Aug 25, 9:21 AM

	Unknown Object (File)
	Tue, Aug 25, 8:26 AM

View All Files

Subscribers

allanjude

Details

Reviewers

manu
rajeshasp
allanjude

Commits

rGce0a9d7c126f: axgbe: Don't dereference NULL pointers

Summary

if (sb == NULL) { ... sb->s_error } is going to be a bad time. Return
ENOMEM when we cannot allocate an sbuf for the sysctl rather than
dereferencing the NULL pointer just returned.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 39332
Build 36221: arc lint + arc unit

Event Timeline

imp requested review of this revision.May 21 2021, 4:51 AM

imp created this revision.

Harbormaster completed remote builds in B39332: Diff 89568.May 21 2021, 4:51 AM

imp added a reviewer: manu.May 21 2021, 4:05 PM

imp added a reviewer: rajeshasp.May 21 2021, 4:09 PM

manu accepted this revision.May 21 2021, 4:09 PM

This revision is now accepted and ready to land.May 21 2021, 4:09 PM

Reviewed By: allanjude

Closed by commit rGce0a9d7c126f: axgbe: Don't dereference NULL pointers (authored by imp). · Explain WhyJun 3 2021, 6:04 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGce0a9d7c126f: axgbe: Don't dereference NULL pointers.

Revision Contents
Changeset List

Path

Size

sys/

dev/

axgbe/

xgbe-sysctl.c

38 lines

Diff 89568

View Options

sys/dev/axgbe/xgbe-sysctl.c

axgbe: Don't dereference NULL pointersClosedPublicActions