Differential D30343

ums(4): Start USB xfers on opening of evdev node unconditionally.
ClosedPublic
Actions

Authored by wulf on May 18 2021, 11:24 PM.

Tags

None

Referenced Files

	F170772338: D30343.id.diff
	Sun, Sep 6, 1:26 PM

	F170770202: D30343.id89458.diff
	Sun, Sep 6, 1:07 PM

	F170710254: D30343.id89458.diff
	Sun, Sep 6, 3:45 AM

	Unknown Object (File)
	Fri, Sep 4, 3:30 AM

	Unknown Object (File)
	Fri, Sep 4, 3:26 AM

	Unknown Object (File)
	Thu, Sep 3, 5:25 PM

	Unknown Object (File)
	Tue, Sep 1, 10:16 PM

	Unknown Object (File)
	Tue, Sep 1, 10:10 PM

Subscribers

Details

Reviewers

Commits

rG7c55c8c7ff72: ums(4): Start USB xfers on opening of evdev node unconditionally.
rG927742783f9e: ums(4): Start USB xfers on opening of evdev node unconditionally.
rG47791339f0cf: ums(4): Start USB xfers on opening of evdev node unconditionally.

Summary

This fixes inability to start USB xfers in a case when FIFO has been
already open()-ed but no read() or poll() calls has been issued yet.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 39286
Build 36175: arc lint + arc unit

Event Timeline

wulf created this revision.May 18 2021, 11:24 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 18 2021, 11:24 PM

wulf requested review of this revision.May 18 2021, 11:24 PM

Harbormaster completed remote builds in B39286: Diff 89458.May 18 2021, 11:24 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 23 2021, 10:44 PM

Closed by commit rG47791339f0cf: ums(4): Start USB xfers on opening of evdev node unconditionally. (authored by wulf). · Explain Why

This revision was automatically updated to reflect the committed changes.

wulf added a commit: rG47791339f0cf: ums(4): Start USB xfers on opening of evdev node unconditionally..

wulf added a commit: rG927742783f9e: ums(4): Start USB xfers on opening of evdev node unconditionally..Jun 13 2021, 10:03 PM

wulf added a commit: rG7c55c8c7ff72: ums(4): Start USB xfers on opening of evdev node unconditionally..Jun 13 2021, 10:08 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

usb/

input/

2 lines

Diff 89458

sys/dev/usb/input/ums.c

Loading...