Page MenuHomeFreeBSD

ktrace: Avoid recursion in namei()
ClosedPublic

Authored by markj on May 18 2021, 8:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 26, 7:54 AM
Unknown Object (File)
Fri, Apr 26, 7:51 AM
Unknown Object (File)
Fri, Apr 26, 3:35 AM
Unknown Object (File)
Fri, Apr 26, 12:15 AM
Unknown Object (File)
Wed, Apr 17, 9:41 AM
Unknown Object (File)
Mar 20 2024, 2:38 AM
Unknown Object (File)
Feb 4 2024, 7:36 AM
Unknown Object (File)
Jan 14 2024, 5:03 AM
Subscribers

Details

Summary

I tried fuzzing ktrace(2) with syzkaller and it found the following bug:
sys_ktrace() calls namei(), which may call ktrnamei(). But sys_ktrace()
also calls ktrace_enter() first, so if the caller is itself being
traced, the assertion in ktrace_enter() is triggered. And, ktrnamei()
does not check for recursion like most other ktrace ops do.

Fix the bug by simply deferring the ktrace_enter() call. I believe it
is safe to perform name resolution from sys_ktrace() even when traced.
Also make the parameter to ktrnamei() const and convert to ANSI.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 39281
Build 36170: arc lint + arc unit