addr2line: skip CUs lacking debug info instead of bailing out
ClosedPublic
Actions

Authored by emaste on Sep 22 2015, 4:13 PM.

Details

Reviewers

cem
royger

Commits

rS288119: addr2line: skip CUs lacking debug info instead of bailing out

Summary

Some binaries (such as the FreeBSD kernel) contain a mixture of CUs with and without debug information. Previously translate() exited upon encountering a CU without debug information. Instead, just move on to the next CU.

Current behaviour:

addr2line -e /usr/lib/debug/boot/kernel/kernel.debug ffffffff80d27d30
addr2line: dwarf_srclines: No entry found [dwarf_srclines(69)]
/tank/emaste/src/git-stable-10/sys/compat/freebsd32/freebsd32_misc.c:3186

With this change:

addr2line -e /usr/lib/debug/boot/kernel/kernel.debug ffffffff80d27d30
/tank/emaste/src/git-stable-10/sys/amd64/amd64/machdep.c:1813

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 8886.Sep 22 2015, 4:13 PM

emaste retitled this revision from to addr2line: skip CUs lacking debug info instead of bailing out.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added a reviewer: royger.

Looks good to me.

This revision is now accepted and ready to land.Sep 22 2015, 4:32 PM

Closed by commit rS288119: addr2line: skip CUs lacking debug info instead of bailing out (authored by emaste). · Explain WhySep 22 2015, 4:51 PM

This revision was automatically updated to reflect the committed changes.

LGTM (phab won't let me "Accept" this because it's Closed).

Revision Contents
Changeset List

Path

Size

head/

contrib/

elftoolchain/

addr2line/

addr2line.c

8 lines

Diff 8889

View Options

head/contrib/elftoolchain/addr2line/addr2line.c

addr2line: skip CUs lacking debug info instead of bailing outClosedPublicActions