Differential D30124

storvsc: fix auto-sense reporting
ClosedPublic
Actions

Authored by avg on May 5 2021, 2:14 PM.

Tags

None

Referenced Files

	F107338224: D30124.diff
	Sun, Jan 12, 5:13 PM

	Unknown Object (File)
	Nov 18 2024, 11:32 AM

	Unknown Object (File)
	Nov 17 2024, 8:50 PM

	Unknown Object (File)
	Nov 10 2024, 10:35 AM

	Unknown Object (File)
	Nov 10 2024, 6:49 AM

	Unknown Object (File)
	Nov 9 2024, 11:19 PM

	Unknown Object (File)
	Oct 18 2024, 7:55 AM

	Unknown Object (File)
	Oct 18 2024, 6:52 AM

View All 49 Files

Subscribers

Details

Reviewers

whu
decui_microsoft.com
imp

Commits

rG8afecefd57c5: storvsc: fix auto-sense reporting

Summary

I saw a situation where the driver set CAM_AUTOSNS_VALID on a failed ccb
even though SRB_STATUS_AUTOSENSE_VALID was not set in the status.
The actual sense data remained all zeros.
The problem seems to be that create_storvsc_request() always sets
hv_storvsc_request::sense_info_len, so checking for sense_info_len != 0
is not enough to determine if any auto-sense data is actually available.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 39027
Build 35916: arc lint + arc unit

Event Timeline

avg created this revision.May 5 2021, 2:14 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 5 2021, 2:14 PM

avg requested review of this revision.May 5 2021, 2:14 PM

Harbormaster completed remote builds in B39027: Diff 88681.May 5 2021, 2:14 PM

avg added reviewers: whu, decui_microsoft.com, imp.May 5 2021, 2:16 PM

The cam part of this looks good. Don't know if that's the right bit to test, but it sure sounds like it

This revision is now accepted and ready to land.May 5 2021, 2:41 PM

Thanks for fixing this.

Closed by commit rG8afecefd57c5: storvsc: fix auto-sense reporting (authored by avg). · Explain WhyMay 7 2021, 7:20 AM

This revision was automatically updated to reflect the committed changes.

avg added a commit: rG8afecefd57c5: storvsc: fix auto-sense reporting.

Revision Contents
Changeset List

Path

Size

sys/

dev/

hyperv/

storvsc/

hv_storvsc_drv_freebsd.c

3 lines

Diff 88681

sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c

Loading...