Differential D29999

fix dwmmc card detect
ClosedPublic
Actions

Authored by br on Apr 26 2021, 7:00 PM.

Details

Reviewers

manu

Commits

rG4c1ecf5502e1: Consider the broken card detect flag that comes from 'broken-cd;'

Summary

Card detect is broken on Altera Stratix10 so use a quirk

Test Plan

tested on Terasic DE10 Pro

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

br requested review of this revision.Apr 26 2021, 7:00 PM

br created this revision.

There is a property in the DTS for that :
https://cgit.freebsd.org/src/tree/sys/contrib/device-tree/src/arm64/altera/socfpga_stratix10_socdk.dts#n111
And we parse this in :
https://cgit.freebsd.org/src/tree/sys/dev/mmc/mmc_fdt_helpers.c#n124
And :
https://cgit.freebsd.org/src/tree/sys/dev/mmc/host/dwmmc.c#n530

So you just need to check this bit in dwmmc.c and don't need a new softc variable or anything in dwmmc_altera.c

manu requested changes to this revision.Apr 26 2021, 7:39 PM

This revision now requires changes to proceed.Apr 26 2021, 7:39 PM

Use broken-cd property

manu added inline comments.Apr 26 2021, 8:48 PM

sys/dev/mmc/host/dwmmc.c
484	I think that should be in () and no need for the '\'

Add ()

manu accepted this revision.Apr 26 2021, 8:57 PM

This revision is now accepted and ready to land.Apr 26 2021, 8:57 PM

Closed by commit rG4c1ecf5502e1: Consider the broken card detect flag that comes from 'broken-cd;' (authored by br). · Explain WhyApr 27 2021, 11:22 AM

This revision was automatically updated to reflect the committed changes.

br added a commit: rG4c1ecf5502e1: Consider the broken card detect flag that comes from 'broken-cd;'.

Revision Contents
Changeset List

Path

Size

sys/

dev/

mmc/

host/

dwmmc.c

3 lines

Diff 88202

View Options

fix dwmmc card detectClosedPublicActions