Page MenuHomeFreeBSD
Differential D29999

fix dwmmc card detect
ClosedPublic
Actions

Authored by br on Apr 26 2021, 7:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 9, 1:39 AM
Unknown Object (File)
Sun, Nov 9, 1:30 AM
Unknown Object (File)
Tue, Nov 4, 6:06 AM
Unknown Object (File)
Mon, Nov 3, 4:11 AM
Unknown Object (File)
Mon, Nov 3, 12:58 AM
Unknown Object (File)
Sun, Nov 2, 8:03 PM
Unknown Object (File)
Sat, Nov 1, 1:03 PM
Unknown Object (File)
Sat, Nov 1, 5:38 AM
View All Files
Subscribers
None

Details

Reviewers
manu
Commits
rG4c1ecf5502e1: Consider the broken card detect flag that comes from 'broken-cd;'
Summary

Card detect is broken on Altera Stratix10 so use a quirk

Test Plan

tested on Terasic DE10 Pro

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

br requested review of this revision.Apr 26 2021, 7:00 PM
br created this revision.
manu added a comment.Apr 26 2021, 7:39 PM

There is a property in the DTS for that :
https://cgit.freebsd.org/src/tree/sys/contrib/device-tree/src/arm64/altera/socfpga_stratix10_socdk.dts#n111
And we parse this in :
https://cgit.freebsd.org/src/tree/sys/dev/mmc/mmc_fdt_helpers.c#n124
And :
https://cgit.freebsd.org/src/tree/sys/dev/mmc/host/dwmmc.c#n530

So you just need to check this bit in dwmmc.c and don't need a new softc variable or anything in dwmmc_altera.c

manu requested changes to this revision.Apr 26 2021, 7:39 PM
This revision now requires changes to proceed.Apr 26 2021, 7:39 PM
br updated this revision to Diff 88200.Apr 26 2021, 8:37 PM

Use broken-cd property

manu added inline comments.Apr 26 2021, 8:48 PM
sys/dev/mmc/host/dwmmc.c
484

I think that should be in () and no need for the '\'

br updated this revision to Diff 88202.Apr 26 2021, 8:52 PM

Add ()

manu accepted this revision.Apr 26 2021, 8:57 PM
This revision is now accepted and ready to land.Apr 26 2021, 8:57 PM
Closed by commit rG4c1ecf5502e1: Consider the broken card detect flag that comes from 'broken-cd;' (authored by br). · Explain WhyApr 27 2021, 11:22 AM
This revision was automatically updated to reflect the committed changes.
br added a commit: rG4c1ecf5502e1: Consider the broken card detect flag that comes from 'broken-cd;'.

Revision Contents
Changeset List

PathSize
sys/
dev/
mmc/
host/
3 lines

Diff 88200

View Options

sys/dev/mmc/host/dwmmc.c

Loading...