Differential D29820

Make pkg use environment variables specified in pkg.conf
ClosedPublic
Actions

Authored by moritz_schmi.tt on Apr 18 2021, 2:15 PM.

Tags

None

Referenced Files

	F164839303: D29820.diff
	Tue, Aug 4, 6:55 AM

	Unknown Object (File)
	Fri, Jul 24, 6:43 PM

	Unknown Object (File)
	Wed, Jul 22, 11:04 PM

	Unknown Object (File)
	Sat, Jul 18, 8:37 AM

	Unknown Object (File)
	Sat, Jul 11, 4:35 PM

	Unknown Object (File)
	Fri, Jul 10, 10:40 PM

	Unknown Object (File)
	Thu, Jul 9, 4:35 PM

	Unknown Object (File)
	Mon, Jul 6, 6:18 AM

Subscribers

Contributor Reviews (src)

Details

Reviewers

bdrewery
bapt

Group Reviewers

Commits

rG3e1022b4eb5f: Make pkg(7) use environment variables specified in pkg.conf
rG3c5d1c587c59: Make pkg(7) use environment variables specified in pkg.conf
rGe869d3c60147: Make pkg(7) use environment variables specified in pkg.conf

Summary

Modify /usr/sbin/pkg to use environment variables specified in pkg.conf.
This allows control over underlying libraries like fetch(3), which can
be configured by setting HTTP_PROXY.

Test Plan

On a freshly installed FreeBSD system that needs to use a proxy for
accessing the internet, set http_proxy as shown in the example in
pkg.conf(5). Without the patch bootstrapping full pkg does not work;
with the patch, everything works as expected.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 38665
Build 35554: arc lint + arc unit

Event Timeline

moritz_schmi.tt created this revision.Apr 18 2021, 2:15 PM

Herald added a reviewer: bdrewery. · View Herald TranscriptApr 18 2021, 2:15 PM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald Transcript

moritz_schmi.tt requested review of this revision.Apr 18 2021, 2:15 PM

Harbormaster completed remote builds in B38665: Diff 87648.Apr 18 2021, 2:15 PM

moritz_schmi.tt added a reviewer: bapt.Apr 18 2021, 2:17 PM

moritz_schmi.tt added a reviewer: pkg.Apr 19 2021, 5:32 PM

bapt accepted this revision.Apr 27 2021, 1:56 AM

This revision is now accepted and ready to land.Apr 27 2021, 1:56 AM

Closed by commit rGe869d3c60147: Make pkg(7) use environment variables specified in pkg.conf (authored by moritz_schmi.tt, committed by bapt). · Explain WhyApr 27 2021, 2:03 AM

This revision was automatically updated to reflect the committed changes.

bapt added a commit: rGe869d3c60147: Make pkg(7) use environment variables specified in pkg.conf.

bapt added a commit: rG3c5d1c587c59: Make pkg(7) use environment variables specified in pkg.conf.May 5 2021, 7:25 AM

bapt added a commit: rG3e1022b4eb5f: Make pkg(7) use environment variables specified in pkg.conf.

Revision Contents
Changeset List

Path

Size

usr.sbin/

pkg/

2 lines

29 lines

Diff 87648

usr.sbin/pkg/config.h

Loading...

usr.sbin/pkg/config.c

Loading...