Page MenuHomeFreeBSD
Differential D29724

[phb]: Fix poudriere ports tree creation instructions
ClosedPublic
Actions

Authored by fernape on Apr 12 2021, 1:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 25, 10:11 PM
Unknown Object (File)
Fri, Mar 20, 6:44 AM
Unknown Object (File)
Thu, Mar 19, 5:34 AM
Unknown Object (File)
Tue, Mar 17, 3:48 AM
Unknown Object (File)
Fri, Mar 13, 4:31 AM
Unknown Object (File)
Fri, Mar 6, 12:43 AM
Unknown Object (File)
Wed, Mar 4, 7:08 PM
Unknown Object (File)
Mon, Mar 2, 8:47 PM
View All 83 Files
Subscribers
None

Details

Reviewers
0mp
gbe
Commits
R9:08fc3edded97: [phb]: Fix poudriere ports tree creation instructions
Summary
  • If using CURRENT, we need to use Git
  • We need the -B flag because our "master" branch is called "main".
Test Plan
  • With current instructions:
[00:00:00] Cloning the ports tree...warning: Could not find remote branch master
to clone.
fatal: Remote branch master not found in upstream origin
[00:00:00] Error:  fail
[00:00:00] Error while creating ports tree, cleaning up.
  • Apply patch and make documentation
  • Review result in browser

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 38529
Build 35418: arc lint + arc unit

Event Timeline

fernape requested review of this revision.Apr 12 2021, 1:21 PM
fernape created this revision.
Harbormaster completed remote builds in B38529: Diff 87305.Apr 12 2021, 1:21 PM
gbe accepted this revision.Apr 16 2021, 4:51 PM

LGTM for the documentation change, but I am not so deep into poudriere stuff.

This revision is now accepted and ready to land.Apr 16 2021, 4:51 PM
fernape added a comment.Apr 16 2021, 4:54 PM
In D29724#668396, @gbe wrote:

LGTM for the documentation change, but I am not so deep into poudriere stuff.

Hi Gordon,

Thanks for the review. I'm pretty positive of the change, but if you feel more comfortable I can bring another pair of eyes from a ports committer to validate the change, or we can ask @0mp since he is a ports committer too.

gbe added a comment.Apr 16 2021, 4:59 PM
In D29724#668399, @fernape wrote:
In D29724#668396, @gbe wrote:

LGTM for the documentation change, but I am not so deep into poudriere stuff.

Hi Gordon,

Thanks for the review. I'm pretty positive of the change, but if you feel more comfortable I can bring another pair of eyes from a ports committer to validate the change, or we can ask @0mp since he is a ports committer too.

@0mp is already in the reviewers list. If you know someone that could have look at the poudriere syntax, just add him as a reviewer.

0mp accepted this revision.Apr 17 2021, 4:43 PM

Sounds good to me!

Closed by commit R9:08fc3edded97: [phb]: Fix poudriere ports tree creation instructions (authored by fernape). · Explain WhyApr 18 2021, 3:49 PM
This revision was automatically updated to reflect the committed changes.
fernape added a commit: R9:08fc3edded97: [phb]: Fix poudriere ports tree creation instructions.

Revision Contents
Changeset List

PathSize
documentation/
content/
en/
books/
porters-handbook/
testing/
4 lines

Diff 87305

View Options

documentation/content/en/books/porters-handbook/testing/_index.adoc

Loading...