Page MenuHomeFreeBSD
Differential D29597

xen/console: add support for HVM and ARM console
AbandonedPublic
Actions

Authored by ehem_freebsd_m5p.com on Apr 6 2021, 1:00 AM.
Tags
None
Referenced Files
F134174814: D29597.id86876.diff
Fri, Oct 31, 9:17 AM
Unknown Object (File)
Mon, Oct 27, 10:12 PM
Unknown Object (File)
Sun, Oct 12, 3:11 PM
Unknown Object (File)
Thu, Oct 9, 3:30 PM
Unknown Object (File)
Fri, Oct 3, 11:21 AM
Unknown Object (File)
Sep 30 2025, 6:48 PM
Unknown Object (File)
Sep 30 2025, 4:24 AM
Unknown Object (File)
Sep 21 2025, 11:24 PM
View All 75 Files
Subscribers
imp
julien_xen.org

Details

Reviewers
royger
mhorne
Summary

This should be improving the console on ARM devices. I'm unsure of the
magnitude of improvement, but it does get a very early console
functioning on ARM devices.

Submitted by: Elliott Mitchell <ehem+freebsd@m5p.com>
Original implementation: Julien Grall <julien@xen.org>, 2015-09-19 10:15:40

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 38346
Build 35235: arc lint + arc unit

Event Timeline

ehem_freebsd_m5p.com created this revision.Apr 6 2021, 1:00 AM
Herald added a subscriber: imp. · View Herald TranscriptApr 6 2021, 1:00 AM
Harbormaster completed remote builds in B38346: Diff 86876.Apr 6 2021, 1:00 AM
ehem_freebsd_m5p.com requested review of this revision.Apr 6 2021, 1:00 AM
ehem_freebsd_m5p.com added a parent revision: D29351: xen: create VM_MEMATTR_XEN for Xen memory mappings.Apr 6 2021, 1:01 AM
royger added a comment.Apr 6 2021, 1:51 PM

I think the comment about pmap not being initialized for HVM needs some clarification.

sys/dev/xen/console/xen_console.c
279

I'm lost here, both HVM and PVH use exactly the same pmap init code, so I'm not sure why pmap_mapdev_attr would work in one case and not the other?

Is maybe something else that's missing, and not pmap initialization?

ehem_freebsd_m5p.com added a comment.Jun 30 2021, 1:45 AM

This one needs @julien_xen.org to comment. So far none of my successful builds lacked this, but a build without it might work.

As such I believe the dependency markings reflect the current situation. I don't know D30950 actually depends on D29597, even though I suspect D30950 depends on D29597.

julien_xen.org added a comment.EditedJun 30 2021, 10:45 AM
In D29597#696444, @ehem_freebsd_m5p.com wrote:

This one needs @julien_xen.org to comment. So far none of my successful builds lacked this, but a build without it might work.

As such I believe the dependency markings reflect the current situation. I don't know D30950 actually depends on D29597, even though I suspect D30950 depends on D29597.

I can't remember why I wrote this patch. If Arm guests are treated as HVM guests, then the behavior doesn't look to change for the initialization.

Can you drop the patch and try to boot?

sys/dev/xen/console/xen_console.c
300

AFAICT, after with the change in xencons_early_init_ring() , cons->evtchn and cons->intf will not be set for PV but HVM domain.

julien_xen.org added inline comments.Jun 30 2021, 10:52 AM
sys/dev/xen/console/xen_console.c
281

I am not sure to understand how the code match the comment. The function will skip the initialisation for non-HVM domain... IOW after this patch, the function will still initialise the ring for HVM domain.

ehem_freebsd_m5p.com removed a parent revision: D29351: xen: create VM_MEMATTR_XEN for Xen memory mappings.Jul 1 2021, 1:00 AM
ehem_freebsd_m5p.com abandoned this revision.Jul 1 2021, 1:27 AM
In D29597#696570, @julien_xen.org wrote:

Can you drop the patch and try to boot?

I don't know whether my build/test setup is worse than others', but I really dislike that test approach as my builds take a while. This though is the test and quite effective. Appears this is no longer necessary, so dropping this. (latest build looked okay in regards to this, even though -CURRENT has some troubles right now)

Revision Contents
Changeset List

PathSize
sys/
dev/
xen/
console/
31 lines

Diff 86876

View Options

sys/dev/xen/console/xen_console.c

Loading...