mail/opendkim: RC style fixes
ClosedPublic
Actions

Authored by crees on Apr 5 2021, 12:44 PM.

Details

Reviewers: None
Commits: R11:0e46cdf18498: mail/opendkim: Respect PidFile setting in opendkim.conf

Summary

There is no need to clean up the piddir, and many of the checks were
just slowing the script down-- we minimise these as much as possible.

The test "x$var" != "x" idiom isn't used in rc scripts as our sh does
not have that bug.

I've moved the functions upwards, and decided not to touch the
profiling parts-- they should be in functions, but they work and
are not the only examples of profiles in this way

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 38322
Build 35211: arc lint + arc unit

Event Timeline

crees created this revision.Apr 5 2021, 12:44 PM

Herald added a subscriber: mat. · View Herald TranscriptApr 5 2021, 12:44 PM

crees requested review of this revision.Apr 5 2021, 12:44 PM

Harbormaster completed remote builds in B38322: Diff 86835.Apr 5 2021, 12:44 PM

PR: ports/25762

Please check using rclint as well
I see multiple maintainer timeouts since 2018 - do you want to take ownership?

mail/opendkim/files/milter-opendkim.in
3	Please rebase, this has been removed lately everywhere

In D29586#688941, @skozlov wrote:

Please check using rclint as well

Who do you think wrote rclint ;)

I see multiple maintainer timeouts since 2018 - do you want to take ownership?

I don't think so thank you. Given maintainer timeout I'm going to commit this under that once I've finished testing-- had to rebase it on the latest lot of changes for this script.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 14 2022, 6:02 PM

Closed by commit R11:0e46cdf18498: mail/opendkim: Respect PidFile setting in opendkim.conf (authored by crees). · Explain Why

This revision was automatically updated to reflect the committed changes.

crees added a commit: R11:0e46cdf18498: mail/opendkim: Respect PidFile setting in opendkim.conf.