Page MenuHomeFreeBSD

mail/opendkim: RC style fixes
ClosedPublic

Authored by crees on Apr 5 2021, 12:44 PM.

Details

Summary

There is no need to clean up the piddir, and many of the checks were
just slowing the script down-- we minimise these as much as possible.

The test "x$var" != "x" idiom isn't used in rc scripts as our sh does
not have that bug.

I've moved the functions upwards, and decided not to touch the
profiling parts-- they should be in functions, but they work and
are not the only examples of profiles in this way

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

crees requested review of this revision.Apr 5 2021, 12:44 PM
  • Please check using rclint as well
  • I see multiple maintainer timeouts since 2018 - do you want to take ownership?
mail/opendkim/files/milter-opendkim.in
1–2

Please rebase, this has been removed lately everywhere

  • Please check using rclint as well

Who do you think wrote rclint ;)

  • I see multiple maintainer timeouts since 2018 - do you want to take ownership?

I don't think so thank you. Given maintainer timeout I'm going to commit this under that once I've finished testing-- had to rebase it on the latest lot of changes for this script.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 14 2022, 6:02 PM
This revision was automatically updated to reflect the committed changes.