cam: make sure to clear CCBs allocated on the stack
ClosedPublic
Actions

Authored by trasz on Mar 29 2021, 1:17 PM.

Details

Reviewers

Group Reviewers

Commits

rG23b90ad00a2a: cam: make sure to clear CCBs allocated on the stack
rG076686fe0703: cam: make sure to clear CCBs allocated on the stack

Summary

This is required for small CCBs support, where we need to track
whether the CCB was allocated from an UMA zone or not. There are
no (intended) functional changes with the current source.

Sponsored by: NetApp, Inc.
Sponsored by: Klara, Inc.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 38155
Build 35044: arc lint + arc unit

Event Timeline

trasz created this revision.Mar 29 2021, 1:17 PM

Herald added a reviewer: cam. · View Herald TranscriptMar 29 2021, 1:18 PM

Herald added a subscriber: imp. · View Herald Transcript

trasz requested review of this revision.Mar 29 2021, 1:18 PM

trasz added a reviewer: imp.Mar 29 2021, 1:18 PM

Harbormaster completed remote builds in B38155: Diff 86490.Mar 29 2021, 1:18 PM

trasz added a subscriber: NetApp.Mar 29 2021, 1:18 PM

As far as I can tell, this looks good. The only thing I worry about is the full CCB we allocate on the stack in the XPT_DEBUG case. but that worry is unrelated to this code review.

This revision is now accepted and ready to land.Mar 29 2021, 3:34 PM

(Tinderboxed.)

Closed by commit rG076686fe0703: cam: make sure to clear CCBs allocated on the stack (authored by trasz). · Explain WhyMar 30 2021, 6:24 PM

This revision was automatically updated to reflect the committed changes.

trasz added a commit: rG076686fe0703: cam: make sure to clear CCBs allocated on the stack.

zlei added a commit: rG23b90ad00a2a: cam: make sure to clear CCBs allocated on the stack.Jan 20 2025, 12:43 PM