qlnxr: remove duplicate defines
ClosedPublic
Actions

Authored by bz on Mar 23 2021, 2:44 PM.

Details

Reviewers

davidcs
• hselasky

Group Reviewers

linuxkpi

Commits

rGf81b4f3be750: qlnxr: remove duplicate defines
rG5df6f7a84058: qlnxr: remove duplicate defines

Summary

upper_32_bits() and lower_32_bits() are defined twice in this file.
With the extra conditinal removed on LinuxKPI they are also included
from there already. Use the LinuxKPI version and remove the two
local ones.

Sponsored-by: The FreeBSD Foundation
Reviewed-by: ..
MFC-after: 2 weeks
Differential Revision:

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz created this revision.Mar 23 2021, 2:44 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 23 2021, 2:44 PM

bz requested review of this revision.Mar 23 2021, 2:44 PM

Harbormaster completed remote builds in B38014: Diff 86200.Mar 23 2021, 2:44 PM

bz added a parent revision: D29391: LinuxKPI: remove < 5.0 version support.Mar 23 2021, 2:44 PM

Looks good to me!

This revision is now accepted and ready to land.Mar 23 2021, 3:49 PM

Closed by commit rG5df6f7a84058: qlnxr: remove duplicate defines (authored by bz). · Explain WhyMar 24 2021, 11:14 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rG5df6f7a84058: qlnxr: remove duplicate defines.

bz added a commit: rGf81b4f3be750: qlnxr: remove duplicate defines.Jul 18 2021, 12:36 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

qlnx/

qlnxr/

qlnxr_verbs.c

5 lines

Diff 86284

View Options

sys/dev/qlnx/qlnxr/qlnxr_verbs.c

qlnxr: remove duplicate definesClosedPublicActions