lib/msun: Fix x86 GCC6 build after 221622ec0c8e184
ClosedPublic
Actions

Authored by arichardson on Mar 12 2021, 6:04 PM.

Details

Reviewers

jhb
imp

Commits

rG6dd6c03efb9e: lib/msun: Fix x86 GCC6 build after 221622ec0c8e184
rG05eac56a0432: lib/msun: Fix x86 GCC6 build after 221622ec0c8e184

Summary

Apparently GCC only supports arithmetic expressions that use static
const variables in initializers starting with GCC8. To keep older
versions happy use a macro instead.

Fixes: 221622ec0c ("lib/msun: Avoid FE_INEXACT for x86 log2l/log10l")
Reported by: Jenkins

Test Plan

compiles now.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson created this revision.Mar 12 2021, 6:04 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 12 2021, 6:04 PM

arichardson requested review of this revision.Mar 12 2021, 6:04 PM

Harbormaster completed remote builds in B37797: Diff 85657.Mar 12 2021, 6:04 PM

imp accepted this revision.Mar 12 2021, 6:13 PM

This revision is now accepted and ready to land.Mar 12 2021, 6:13 PM

Closed by commit rG05eac56a0432: lib/msun: Fix x86 GCC6 build after 221622ec0c8e184 (authored by arichardson). · Explain WhyMar 12 2021, 6:45 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rG05eac56a0432: lib/msun: Fix x86 GCC6 build after 221622ec0c8e184.

arichardson added a commit: rG6dd6c03efb9e: lib/msun: Fix x86 GCC6 build after 221622ec0c8e184.Apr 22 2021, 11:09 AM

Revision Contents
Changeset List

Path

Size

lib/

msun/

ld80/

s_logl.c

16 lines

Diff 85662

View Options

lib/msun/ld80/s_logl.c

This file was added.

Property	Old Value	New Value
fbsd:nokeywords	null	yes \ No newline at end of property
svn:eol-style	null	native \ No newline at end of property
svn:mime-type	null	text/plain \ No newline at end of property

				--- src/librustc_llvm/build.rs.orig 2017-01-18 02:20:03 UTC
				+++ src/librustc_llvm/build.rs
				@@ -234,6 +234,8 @@ fn main() {
				// OpenBSD has a particular C++ runtime library name
				let stdcppname = if target.contains("openbsd") {
				"estdc++"
				+ } else if target.contains("freebsd") {
				+ "c++"
				} else {
				"stdc++"
				};

lib/msun: Fix x86 GCC6 build after 221622ec0c8e184ClosedPublicActions