Page MenuHomeFreeBSD
Differential D29047

Modernize geom_stats_snapshot_get
ClosedPublic
Actions

Authored by asomers on Mar 3 2021, 8:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 10, 11:58 PM
Unknown Object (File)
Sun, Sep 6, 12:55 PM
Unknown Object (File)
Sun, Sep 6, 2:28 AM
Unknown Object (File)
Sat, Sep 5, 5:03 PM
Unknown Object (File)
Sat, Sep 5, 11:19 AM
Unknown Object (File)
Sat, Sep 5, 7:01 AM
Unknown Object (File)
Fri, Sep 4, 12:59 PM
Unknown Object (File)
Wed, Sep 2, 8:33 AM
View All Files
Subscribers
imp

Details

Reviewers
phk
Commits
rGe0c4ed73f3a6: Modernize geom_stats_snapshot_get
rG774abe650b84: Modernize geom_stats_snapshot_get
rGf05b724ecb31: Modernize geom_stats_snapshot_get
Summary
  • A logically useless memset() is used to fault in some memory pages. Change it to explicit_bzero so the compiler won't eliminate it.
  • Eliminate the second memset. It made sense in the days of the Big Kernel Lock, but not in the days of fine-grained SMP and especially not in the days of VDSO.

MFC after: 2 weeks
Sponsored by: Axcient

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37547
Build 34436: arc lint + arc unit

Revision Contents
Changeset List

PathSize
lib/
libgeom/
3 lines

Diff 85072

View Options

lib/libgeom/geom_stats.c

Loading...