printf: Avoid setting FE_INEXACT in printf()
AcceptedPublic
Actions

Authored by arichardson on Feb 19 2021, 12:57 PM.

Details

Reviewers

Summary

The k = (int)ds; cast inside gdtoa/dtoa can set FE_INEXACT.
Having printf() change the FE_INEXACT flag results in some of the
msun tests failing when compiling them with debugging flags.
To avoid this, save the state of FE_INEXACT before calling gdtoa()
and clear it if gdtoa() set it.

Test Plan

building msun with -DDOPRINT -DDEBUG -DDOPRINT_LD80 no longer causes all tests to fail

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 37185
Build 34074: arc lint + arc unit

Event Timeline

arichardson created this revision.Feb 19 2021, 12:57 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 19 2021, 12:57 PM

arichardson requested review of this revision.Feb 19 2021, 12:57 PM

Harbormaster completed remote builds in B37185: Diff 84256.Feb 19 2021, 12:58 PM

arichardson mentioned this in D28798: Convert the msun tests to ATF.Feb 19 2021, 5:32 PM

Hm, wouldn't it be better to fix this in gdtoa() instead? Then it would be solved for all gdtoa() consumers. That said, I've understood that the gdtoa code is very impenetrable...

In D28787#646949, @dim wrote:

Hm, wouldn't it be better to fix this in gdtoa() instead? Then it would be solved for all gdtoa() consumers. That said, I've understood that the gdtoa code is very impenetrable...

I had a brief look at modifying the gdtoa code, but it seemed to be quite akward so I chose to change the wrapper instead.

In D28787#646959, @arichardson wrote:

In D28787#646949, @dim wrote:

Hm, wouldn't it be better to fix this in gdtoa() instead? Then it would be solved for all gdtoa() consumers. That said, I've understood that the gdtoa code is very impenetrable...

I had a brief look at modifying the gdtoa code, but it seemed to be quite akward so I chose to change the wrapper instead.