Eliminate setgid leftover in w(1).
ClosedPublic
Actions

Authored by delphij on Sep 1 2015, 6:13 AM.

Tags

None

Referenced Files

	F122285360: D3541.id8618.diff
	Fri, Jul 4, 1:42 AM

	Unknown Object (File)
	Fri, Jun 20, 7:22 AM

	Unknown Object (File)
	Thu, Jun 19, 7:09 PM

	Unknown Object (File)
	Sun, Jun 15, 11:07 AM

	Unknown Object (File)
	Tue, Jun 10, 7:04 PM

	Unknown Object (File)
	May 22 2025, 8:31 AM

	Unknown Object (File)
	Apr 24 2025, 3:30 AM

	Unknown Object (File)
	Apr 24 2025, 1:54 AM

View All 81 Files

Subscribers

imp

wollman

Details

Reviewers

peter
wollman

Group Reviewers

security
secteam

Commits

rS287590: w(1) is not setgid binary since r53279, so remove the setgid() call.

Summary

w(1) is not sgid binary since r53279. We should either unconditionally
do setgid() if we are really concerned, or just get rid of the setgid
bits.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 329
Build 329: arc lint + arc unit

Event Timeline

delphij updated this revision to Diff 8380.Sep 1 2015, 6:13 AM

delphij retitled this revision from to Eliminate setgid leftover in w(1)..

delphij updated this object.

delphij edited the test plan for this revision. (Show Details)

delphij added a reviewer: peter.

Herald added a subscriber: imp. · View Herald TranscriptSep 1 2015, 6:13 AM

delphij added reviewers: secteam, security.Sep 1 2015, 6:34 AM

Makes sense to me.

This revision is now accepted and ready to land.Sep 6 2015, 8:28 PM

Closed by commit rS287590: w(1) is not setgid binary since r53279, so remove the setgid() call. (authored by delphij). · Explain WhySep 9 2015, 5:17 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

usr.bin/

Makefile

2 lines

w.c

12 lines

Diff 8380

View Options

usr.bin/w/Makefile