hid: bump HID_ITEM_MAXUSAGES to 8
ClosedPublic
Actions

Authored by imp on Feb 8 2021, 7:37 PM.

Details

Reviewers

Commits

rG5a1ecfa5a986: hid: bump HID_ITEM_MAXUSAGES to 8
rG0dc5c9467b5b: hid: bump HID_ITEM_MAXUSAGES to 8
rGdb2f512381ac: hid: bump HID_ITEM_MAXUSAGES to 8

Summary

My YOGA requires a minimum of 7 to parse w/o an error. Since the memory
savings are trivial and the yoga a popular system, bump the default
up to 8. There's no API/ABI issues in doing this. This hid_item
struct isn't exported to userland and the one libusbhid has is
different and only shares a name...

MFC After: 3 days

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 36813
Build 33702: arc lint + arc unit

Event Timeline

imp requested review of this revision.Feb 8 2021, 7:37 PM

imp created this revision.

Harbormaster completed remote builds in B36813: Diff 83563.Feb 8 2021, 7:37 PM

imp edited the summary of this revision. (Show Details)Feb 8 2021, 7:39 PM

imp added a reviewer: wulf.

Could you share the HID report descriptor of your device?

This revision is now accepted and ready to land.Feb 8 2021, 9:42 PM

In D28543#638950, @wulf wrote:

Could you share the HID report descriptor of your device?

How do I do that?

Closed by commit rGdb2f512381ac: hid: bump HID_ITEM_MAXUSAGES to 8 (authored by imp). · Explain WhyFeb 8 2021, 10:32 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGdb2f512381ac: hid: bump HID_ITEM_MAXUSAGES to 8.

In D28543#638978, @imp wrote:

In D28543#638950, @wulf wrote:

Could you share the HID report descriptor of your device?

How do I do that?

# kldload hidraw.ko
# usbhidctl -f /dev/hidraw# -r

Ouch, I forgot that usbhidctl is unable nor properly parse such a descriptor nor do a raw dump. So no easy way right now, rebuilding of kernel with debug options enabled is required. Just forget.

imp added a commit: rG0dc5c9467b5b: hid: bump HID_ITEM_MAXUSAGES to 8.Feb 11 2021, 5:14 AM

imp added a commit: rG5a1ecfa5a986: hid: bump HID_ITEM_MAXUSAGES to 8.Mar 1 2021, 7:00 PM