Page MenuHomeFreeBSD

hid: bump HID_ITEM_MAXUSAGES to 8
ClosedPublic

Authored by imp on Feb 8 2021, 7:37 PM.

Details

Summary

My YOGA requires a minimum of 7 to parse w/o an error. Since the memory
savings are trivial and the yoga a popular system, bump the default
up to 8. There's no API/ABI issues in doing this. This hid_item
struct isn't exported to userland and the one libusbhid has is
different and only shares a name...

MFC After: 3 days

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

imp requested review of this revision.Feb 8 2021, 7:37 PM
imp created this revision.
imp added a reviewer: wulf.

Could you share the HID report descriptor of your device?

This revision is now accepted and ready to land.Feb 8 2021, 9:42 PM
In D28543#638950, @wulf wrote:

Could you share the HID report descriptor of your device?

How do I do that?

This revision was automatically updated to reflect the committed changes.
In D28543#638978, @imp wrote:
In D28543#638950, @wulf wrote:

Could you share the HID report descriptor of your device?

How do I do that?

# kldload hidraw.ko
# usbhidctl -f /dev/hidraw# -r

Ouch, I forgot that usbhidctl is unable nor properly parse such a descriptor nor do a raw dump. So no easy way right now, rebuilding of kernel with debug options enabled is required. Just forget.