Page MenuHomeFreeBSD
Differential D3523

Update net/rtpproxy to 2.0.0
ClosedPublic
Actions

Authored by farrokhi on Aug 28 2015, 7:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 31, 10:56 PM
Unknown Object (File)
Thu, Oct 31, 10:26 AM
Unknown Object (File)
Thu, Oct 31, 5:46 AM
Unknown Object (File)
Tue, Oct 29, 8:00 PM
Unknown Object (File)
Tue, Oct 29, 4:28 PM
Unknown Object (File)
Mon, Oct 28, 8:50 AM
Unknown Object (File)
Thu, Oct 24, 5:51 AM
Unknown Object (File)
Thu, Oct 24, 12:26 AM
View All Files
Subscribers
None

Details

Reviewers
philip
bapt
mat
Commits
rP395556: net/rtpproxy:
Summary

net/rtpproxy:

  • update to 2.0.0
  • take maintainership

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 300
Build 300: arc lint + arc unit

Event Timeline

farrokhi updated this revision to Diff 8312.Aug 28 2015, 7:44 PM
farrokhi retitled this revision from to Update net/rtpproxy to 2.0.0.
farrokhi updated this object.
farrokhi edited the test plan for this revision. (Show Details)
farrokhi added reviewers: philip, bapt, mat.
mat added inline comments.Aug 28 2015, 9:06 PM
net/rtpproxy/Makefile
7–8

Remove that line, it's the default when USE_GITHUB is defined.

18

use DISTVERSIONPREFIX=v (and put that line just below the PORTVERSION one. (it'll change the DISTNAME, so you will need to rerun make makesum)

farrokhi updated this revision to Diff 8322.Aug 29 2015, 5:00 AM
farrokhi marked 2 inline comments as done.
  • Minor cleanups in Makefile
mat added inline comments.Aug 29 2015, 6:16 AM
net/rtpproxy/Makefile
7–8

The MASTER_SITES line should be removed.

farrokhi updated this revision to Diff 8323.Aug 29 2015, 6:27 AM
farrokhi marked an inline comment as done.
  • Removed MASTER_SITES definition
mat added inline comments.Aug 29 2015, 6:55 AM
net/rtpproxy/Makefile
6

Missing a tabulation after = here.

16–17

I think there's a space here after the = sign, it should be a tabulation. portlint should tell you this.

net/rtpproxy/pkg-plist
1

This should not be in the plist, there should be a USE_RC_SUBR= ${PORTNAME} in the Makefile.

farrokhi updated this revision to Diff 8325.Aug 29 2015, 7:10 AM
farrokhi marked an inline comment as done.
  • minor Makefile improvements
farrokhi added inline comments.Aug 29 2015, 7:12 AM
net/rtpproxy/Makefile
16–17

They are tabs actually, and portlint didn't complain.

net/rtpproxy/pkg-plist
1

Actually RC_SUBR comes bundled with the source and is not taken from local patch files. We only improved it using a patch. portlint complains when I use USE_RC_SUBR in this case.

mat added inline comments.Aug 29 2015, 7:37 AM
net/rtpproxy/pkg-plist
1

Mmm, or no, USE_RC_SUBR should only be used when the rc script is in the files directory, sorry for the noise.

mat added inline comments.Aug 29 2015, 8:05 AM
net/rtpproxy/Makefile
16–17

One thing portlint could do, and it did not…

19

Ok, so, I told you crap, don't put this here, it's going to assume you have files/PORTNAME.in file.

farrokhi updated this revision to Diff 8326.Aug 29 2015, 8:46 AM
farrokhi marked 3 inline comments as done.
  • removed unnecessary USE_RC_SUBR
mat accepted this revision.Aug 29 2015, 8:58 AM
mat edited edge metadata.

If it builds, approved

Macro shipit:

This revision is now accepted and ready to land.Aug 29 2015, 8:58 AM
mat added a comment.Aug 29 2015, 9:00 AM

btw, your shell account should be ok now, before committing any ports, do follow the steps for new committers here https://www.freebsd.org/doc/en/articles/committers-guide/conventions.html (if there are you had not performed when you first became a committer)

Also, setup your email forwarding (it's explained in the motd if you ssh on freefall).

Closed by commit rP395556: net/rtpproxy: (authored by farrokhi). · Explain WhyAug 29 2015, 1:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
net/
rtpproxy/
14 lines
4 lines
files/
patch-scripts_rtpproxy.in.freebsd
patch-freebsd_rtpproxy.in
6 lines
1 line

Diff 8325

View Options

net/rtpproxy/Makefile

Loading...
View Options

net/rtpproxy/distinfo

Loading...
View Options

net/rtpproxy/files/patch-freebsd_rtpproxy.in

Loading...
View Options

net/rtpproxy/files/patch-scripts_rtpproxy.in.freebsd

Loading...
View Options

net/rtpproxy/pkg-plist

Loading...