Page MenuHomeFreeBSD

sysutils/onefetch: Update to 2.9.1
ClosedPublic

Authored by lcook on Jan 22 2021, 2:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 21 2024, 7:49 PM
Unknown Object (File)
Mar 16 2024, 4:30 PM
Unknown Object (File)
Mar 16 2024, 4:30 PM
Unknown Object (File)
Mar 16 2024, 4:30 PM
Unknown Object (File)
Mar 16 2024, 4:18 PM
Unknown Object (File)
Jan 29 2024, 9:43 AM
Unknown Object (File)
Dec 21 2023, 8:10 PM
Unknown Object (File)
Dec 20 2023, 4:33 AM
Subscribers

Details

Summary

Changelog:

QA:

  • portlint: OK (looks fine).
  • testport: OK (poudriere: 12.2-RELEASE-p2, amd64).

MFH: No (Feature changes).

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 36407
Build 33296: arc lint + arc unit

Event Timeline

lcook requested review of this revision.Jan 22 2021, 2:18 PM

Builds fine in {11.4,12.2}{amd64,i386} and 13-current amd64.

Runs fine in 12.2amd64.

sysutils/onefetch/Makefile
26

Only ansi_term-0.11.0 seems to be used

29

Is this right? Does the port use two different versions of arrayvec? It seems to use only one:

$ grep arrayvec-0 11_4amd64-default.log | grep rustc

Running `/usr/local/bin/rustc --crate-name build_script_build /wrkdirs/usr/ports/sysutils/onefetch/work/onefetch-2.9.1/cargo-crates/---->arrayvec-0.4.12<----/build.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type bin --emit=dep-info,link -C embed-bitcode=no -C debug-assertions=off --cfg 'feature="default"' --cfg 'feature="std"' -C metadata=b73d0c5df4d742d6 -C extra-filename=-b73d0c5df4d742d6 --out-dir /wrkdirs/usr/ports/sysutils/onefetch/work/target/release/build/arrayvec-b73d0c5df4d742d6 -L dependency=/wrkdirs/usr/ports/sysutils/onefetch/work/target/release/deps --cap-lints allow -C linker=cc -C link-arg=-fstack-protector-strong`
Running `/usr/local/bin/rustc --crate-name arrayvec /wrkdirs/usr/ports/sysutils/onefetch/work/onefetch-2.9.1/cargo-crates/---->arrayvec-0.4.12<----/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts --crate-type lib --emit=dep-info,metadata,link -C opt-level=2 -C embed-bitcode=no --cfg 'feature="default"' --cfg 'feature="std"' -C metadata=2019423eeb3da5b3 -C extra-filename=-2019423eeb3da5b3 --out-dir /wrkdirs/usr/ports/sysutils/onefetch/work/target/release/deps -L dependency=/wrkdirs/usr/ports/sysutils/onefetch/work/target/release/deps --extern nodrop=/wrkdirs/usr/ports/sysutils/onefetch/work/target/release/deps/libnodrop-5ca4a67dc7cf777e.rmeta --cap-lints allow -C linker=cc -C link-arg=-fstack-protector-strong --cfg has_stable_maybe_uninit`
81

Only getrandom-0.2.1 seems to be used

Builds fine in {11.4,12.2}{amd64,i386} and 13-current amd64.

Runs fine in 12.2amd64.

Refer to PR251500 comment#2. As seen, these double-listings span across (getrandom, for example) varying ports in what I presume are indirect dependencies, where particular projects explicitly lock to a version whilst others don't - causing multiple versions to be listed in the CARGO_CRATES. Otherwise, it's merely my effort of running make cargo-crates ;-)

To further elaborate, let's take a look at the line:

arrayvec-0.4.12 \
arrayvec-0.5.2 \

And compare to the projects Cargo.lock (corresponding to those two crates):

[[package]]
name = "blake2b_simd"
version = "0.5.11"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "afa748e348ad3be8263be728124b24a24f268266f6f5d58af9d75f6a40b5c587"
dependencies = [
 "arrayref",
 "arrayvec 0.5.2",
 "constant_time_eq",
]

And...

[[package]]
name = "num-format"
version = "0.4.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "bafe4179722c2894288ee77a9f044f02811c86af699344c498b0840c698a2465"
dependencies = [
 "arrayvec 0.4.12",
 "itoa",
]

As you can see, this is where both those crates versions are being pulled in from and looks to be the case for the others, too. :-)

Builds fine in {11.4,12.2}{amd64,i386} and 13-current amd64.

Runs fine in 12.2amd64.

Refer to PR251500 comment#2. As seen, these double-listings span across (getrandom, for example) varying ports in what I presume are indirect dependencies, where particular projects explicitly lock to a version whilst others don't - causing multiple versions to be listed in the CARGO_CRATES. Otherwise, it's merely my effort of running make cargo-crates ;-)

OK, I see. clap v2.33.3 requires ansi_term = 0.11 specifically and reports it can not work with 0.12.1.

To further elaborate, let's take a look at the line:

arrayvec-0.4.12 \
arrayvec-0.5.2 \

And compare to the projects Cargo.lock (corresponding to those two crates):

[[package]]
name = "blake2b_simd"
version = "0.5.11"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "afa748e348ad3be8263be728124b24a24f268266f6f5d58af9d75f6a40b5c587"
dependencies = [
 "arrayref",
 "arrayvec 0.5.2",
 "constant_time_eq",
]

And...

[[package]]
name = "num-format"
version = "0.4.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "bafe4179722c2894288ee77a9f044f02811c86af699344c498b0840c698a2465"
dependencies = [
 "arrayvec 0.4.12",
 "itoa",
]

As you can see, this is where both those crates versions are being pulled in from and looks to be the case for the others, too. :-)

This revision is now accepted and ready to land.Jan 23 2021, 5:32 PM
This revision was automatically updated to reflect the committed changes.