Return errors in bus_dmamap_load
AbandonedPublic
Actions

Authored by kjopek_gmail.com on Jan 20 2021, 10:12 PM.

Details

Reviewers

mmel
manu
kib

Summary

Function bus_dmamap_load returned only two different errors: EINPROGRESS and ENOMEM.
However, some implementations (arm64 notably) provide more errors here. Do not limit set of errors
bus_dmamap_load returns.

While here: hint compiler on fast path in the code.

Test Plan

Tested on RockPro64.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kjopek_gmail.com requested review of this revision.Jan 20 2021, 10:12 PM

kjopek_gmail.com created this revision.

mmel added a reviewer: kib.Jan 21 2021, 8:15 AM

Kib, this error handling doesn't make sense to me, so I had to miss something important. Can you, please, explain me the context/reason for this strange kind of errors hiding? Moreover EBIG is also allowed in man page.

sys/kern/subr_bus_dma.c
405	Style. Assuming that this will be applied to all bus_dmamap_load<foo>() variants.
437	(error = 0)

In D28261#632241, @mmel wrote:

Kib, this error handling doesn't make sense to me, so I had to miss something important. Can you, please, explain me the context/reason for this strange kind of errors hiding? Moreover EBIG is also allowed in man page.

EBIG is an error shown to callback. That said, I am not the author of this code and if I blamed for it, perhaps because I moved it around, nothing more.

I am certain that the intent is that callback should consume the error and make required arrangements. Blindly leaking something different than ENOMEM/EINPROGRESS from bus_dmamap_load() potentially breaks callers, they all must be inspected before.

kjopek_gmail.com abandoned this revision.Mar 30 2021, 11:26 AM

Revision Contents
Changeset List

Path

Size

sys/

kern/

subr_bus_dma.c

18 lines

Diff 82660

View Options

Return errors in bus_dmamap_loadAbandonedPublicActions