Differential D27922

if_vtnet: Schedule Rx task if pending items when enabling interrupt
ClosedPublic
Actions

Authored by bryanv on Jan 2 2021, 9:17 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jul 7, 10:38 AM

	Unknown Object (File)
	Fri, Jul 4, 7:09 PM

	Unknown Object (File)
	Thu, Jul 3, 1:18 PM

	Unknown Object (File)
	Wed, Jul 2, 1:02 PM

	Unknown Object (File)
	Tue, Jul 1, 10:14 PM

	Unknown Object (File)
	Tue, Jul 1, 4:54 PM

	Unknown Object (File)
	Mon, Jun 30, 1:13 PM

	Unknown Object (File)
	Mon, Jun 30, 7:02 AM

View All 63 Files

Subscribers

Details

Reviewers

Commits

rG4f18e23f8432: if_vtnet: Schedule Rx task if pending items when enabling interrupt

Summary

Prior to V1, the driver would enable interupts and then notify the
host that DRIVER_OK. Since for V1, DRIVER_OK needs to be set before
notifying the virtqueues, there may be items in the queues waiting
to be processed by the time interrupts are enabled.

This fixes a bug where the first Rx queue would appear stuck, only
being fixable by an interface down/up.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bryanv created this revision.Jan 2 2021, 9:17 PM

bryanv held this revision as a draft.

Herald added a subscriber: imp. · View Herald TranscriptJan 2 2021, 9:17 PM

Harbormaster completed remote builds in B35887: Diff 81545.Jan 2 2021, 9:17 PM

bryanv added a reviewer: grehan.Jan 2 2021, 9:17 PM

bryanv published this revision for review.Jan 2 2021, 10:05 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 19 2021, 5:12 AM

Closed by commit rG4f18e23f8432: if_vtnet: Schedule Rx task if pending items when enabling interrupt (authored by bryanv). · Explain Why

This revision was automatically updated to reflect the committed changes.

bryanv added a commit: rG4f18e23f8432: if_vtnet: Schedule Rx task if pending items when enabling interrupt.

Revision Contents
Changeset List

Path

Size

sys/

dev/

virtio/

network/

14 lines

Diff 82548

sys/dev/virtio/network/if_vtnet.c

Loading...