Paths

Table of Contentst

Differential D28130

elftcl: add -i flag to ignore unknown flags
ClosedPublic
Actions

Authored by emaste on Jan 13 2021, 3:29 AM.

Tags

None

Referenced Files

	F132760596: D28130.id82188.diff
	Sun, Oct 19, 5:44 PM

	Unknown Object (File)
	Sat, Oct 18, 1:30 AM

	Unknown Object (File)
	Fri, Oct 17, 9:21 AM

	Unknown Object (File)
	Thu, Oct 16, 11:44 PM

	Unknown Object (File)
	Thu, Oct 16, 11:44 PM

	Unknown Object (File)
	Thu, Oct 16, 11:44 PM

	Unknown Object (File)
	Thu, Oct 16, 11:43 PM

	Unknown Object (File)
	Thu, Oct 16, 11:43 PM

Subscribers

None

Details

Reviewers

kib
markj

Commits

rG369a4023e671: elftcl: add -i flag to ignore unknown flags
rGf6d95a01103a: elftcl: add -i flag to ignore unknown flags

Summary

This may allow an identical elfctl invocation to be used on multiple FreeBSD versions, with features not implemented on older releases being silently ignored.

PR: 252629 (related)
MFC after: 1 week
Sponsored by: The FreeBSD Foundation

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste requested review of this revision.Jan 13 2021, 3:29 AM

emaste created this revision.

emaste added a reviewer: markj.

kib added inline comments.Jan 13 2021, 4:00 AM

usr.bin/elfctl/elfctl.c
206	Add -i flag there ?
235	I suggest to print something anyway, so e.g. typos are still being caught. May be add quit mode where nothing is printed at all but I am not sure it is needed.

leave warning in place with -i, per kib

add -i to usage, per kib

kib accepted this revision.Jan 13 2021, 5:03 AM

This revision is now accepted and ready to land.Jan 13 2021, 5:03 AM

Closed by commit rGf6d95a01103a: elftcl: add -i flag to ignore unknown flags (authored by emaste). · Explain WhyJan 13 2021, 5:12 AM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGf6d95a01103a: elftcl: add -i flag to ignore unknown flags.

emaste added a commit: rG369a4023e671: elftcl: add -i flag to ignore unknown flags.Jan 19 2021, 2:50 AM

Revision Contents
Changeset List

Path

Size

usr.bin/

elfctl/

6 lines

12 lines

Diff 82187

usr.bin/elfctl/elfctl.1

Loading...

usr.bin/elfctl/elfctl.c

Loading...