prepare-commit-msg: Avoid warning on macOS and shellcheck fixes
ClosedPublic
Actions

Authored by arichardson on Jan 7 2021, 9:56 AM.

Details

Reviewers

emaste

Commits

rGd146f831801f: prepare-commit-msg: Avoid warning on macOS and shellcheck fixes

Summary

The macOS /bin/sh complains about using return outside of functions.
Replace return 0 with exit 0 to fix this. While editing this files
I've also fixed all the shellcheck warnings that were displayed by my IDE.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 35988
Build 32877: arc lint + arc unit

Event Timeline

arichardson created this revision.Jan 7 2021, 9:56 AM

Herald added a subscriber: imp. · View Herald TranscriptJan 7 2021, 9:56 AM

Harbormaster completed remote builds in B35988: Diff 81789.Jan 7 2021, 9:56 AM

arichardson requested review of this revision.Jan 7 2021, 9:56 AM

emaste accepted this revision.Jan 7 2021, 1:55 PM

This revision is now accepted and ready to land.Jan 7 2021, 1:55 PM

Closed by commit rGd146f831801f: prepare-commit-msg: Avoid warning on macOS and shellcheck fixes (authored by arichardson). · Explain WhyJan 7 2021, 2:01 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rGd146f831801f: prepare-commit-msg: Avoid warning on macOS and shellcheck fixes.

Revision Contents
Changeset List

Path

Size

tools/

git/

hooks/

prepare-commit-msg

10 lines

Diff 81789

View Options

tools/tools/git/hooks/prepare-commit-msg

prepare-commit-msg: Avoid warning on macOS and shellcheck fixesClosedPublicActions