Use more standard types for manipulating pointers.
ClosedPublic
Actions

Authored by jhb on Dec 11 2020, 9:26 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 23, 11:01 PM

	Unknown Object (File)
	Tue, Dec 16, 11:37 AM

	Unknown Object (File)
	Sun, Dec 14, 4:37 PM

	Unknown Object (File)
	Fri, Dec 12, 9:57 PM

	Unknown Object (File)
	Nov 14 2025, 5:21 AM

	Unknown Object (File)
	Nov 9 2025, 6:06 PM

	Unknown Object (File)
	Nov 8 2025, 10:41 PM

	Unknown Object (File)
	Nov 8 2025, 10:26 PM

View All Files

Subscribers

imp

vidwer_fbsdbugs_gmail.com

Details

Reviewers

imp
• hselasky

Commits

rS368688: Use more standard types for manipulating pointers.

Summary

Use a uintptr_t cast to get the virtual address of a pointer in USB_P2U() instead of a ptrdiff_t.

Add offsets to a char * pointer directly without roundtripping the pointer through a ptrdiff_t in USB_ADD_BYTES().

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Dec 11 2020, 9:26 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 11 2020, 9:26 PM

jhb requested review of this revision.Dec 11 2020, 9:26 PM

Harbormaster completed remote builds in B35361: Diff 80610.Dec 11 2020, 9:26 PM

imp accepted this revision.Dec 11 2020, 10:28 PM

This revision is now accepted and ready to land.Dec 11 2020, 10:28 PM

jhb added a reviewer: • hselasky.Dec 12 2020, 4:53 PM

Just make sure stand/usb builds too before committing.

Closed by commit rS368688: Use more standard types for manipulating pointers. (authored by jhb). · Explain WhyDec 16 2020, 12:27 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS368688: Use more standard types for manipulating pointers..

vidwer_fbsdbugs_gmail.com added a subscriber: vidwer_fbsdbugs_gmail.com.Dec 24 2020, 5:26 PM

This comment was removed by vidwer_fbsdbugs_gmail.com.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

usb/

usb_core.h

4 lines

Diff 80739

View Options

head/sys/dev/usb/usb_core.h

Use more standard types for manipulating pointers.ClosedPublicActions