Use uintptr_t instead of unsigned long for integers holding pointers.
ClosedPublic
Actions

Authored by jhb on Dec 11 2020, 9:26 PM.

Details

Reviewers

imp
gallatin

Commits

rS368687: Use uintptr_t instead of unsigned long for integers holding pointers.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 35360
Build 32286: arc lint + arc unit

Event Timeline

jhb created this revision.Dec 11 2020, 9:26 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 11 2020, 9:26 PM

Harbormaster completed remote builds in B35360: Diff 80609.Dec 11 2020, 9:26 PM

jhb requested review of this revision.Dec 11 2020, 9:26 PM

Unions might be better for this, but these casts look good and are a more minimal change.

This revision is now accepted and ready to land.Dec 11 2020, 10:27 PM

Well, the other fix is to use something like __aligned or __alignas, but I went for minimal changes, especially given that this driver is probably not as widely used.

jhb added a reviewer: gallatin.Dec 12 2020, 4:52 PM

In D27580#616464, @jhb wrote:

Well, the other fix is to use something like __aligned or __alignas, but I went for minimal changes, especially given that this driver is probably not as widely used.

Yea. Makes sense. Likely not that important for this driver.

gallatin accepted this revision.Dec 14 2020, 1:26 AM

Closed by commit rS368687: Use uintptr_t instead of unsigned long for integers holding pointers. (authored by jhb). · Explain WhyDec 16 2020, 12:18 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS368687: Use uintptr_t instead of unsigned long for integers holding pointers..