Page MenuHomeFreeBSD
Differential D27339

Fix double unlock if the source file disappears
ClosedPublic
Actions

Authored by trasz on Nov 23 2020, 1:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 15, 11:33 PM
Unknown Object (File)
Fri, May 15, 11:32 PM
Unknown Object (File)
Fri, May 15, 11:32 PM
Unknown Object (File)
Fri, May 15, 11:32 PM
Unknown Object (File)
Mon, May 11, 5:01 AM
Unknown Object (File)
Sun, May 3, 4:50 PM
Unknown Object (File)
Mon, Apr 27, 12:41 PM
Unknown Object (File)
Apr 22 2026, 10:30 AM
View All Files
Subscribers
imp
NetApp

Details

Reviewers
kib
Commits
rGe681d7d702d6: msdosfs: fix double unlock if the source file disappears
rGcb6962124959: msdosfs: fix double unlock if the source file disappears
Summary

Fix double unlock if the source file disappears; we would
unlock it here, only to unlock it again below, just before "bad".

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34981
Build 31974: arc lint + arc unit

Event Timeline

trasz created this revision.Nov 23 2020, 1:58 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 23 2020, 1:58 PM
trasz requested review of this revision.Nov 23 2020, 1:58 PM
Harbormaster completed remote builds in B34981: Diff 79898.Nov 23 2020, 1:58 PM
trasz added a subscriber: NetApp.Nov 23 2020, 1:58 PM
kib added inline comments.Nov 23 2020, 2:29 PM
sys/fs/msdosfs/msdosfs_vnops.c
1144

So why this vrele() uses a_vfp pointer instead of fvp ? Is it possible that they are different (doubt it). If so wouldn't it be more natural to stop these intermediate vrele/unlocks, replacing them by final vput(fvp) ?

trasz added inline comments.Nov 24 2020, 10:59 AM
sys/fs/msdosfs/msdosfs_vnops.c
1144

It is possible they are different - this code happens after a call to relookup(), which can change fvp. In fact, it has to be different, given the conditional ("xp != ip").

kib accepted this revision.Dec 3 2020, 1:14 PM
This revision is now accepted and ready to land.Dec 3 2020, 1:14 PM
trasz added a comment.Jan 26 2021, 4:58 PM

(Tinderboxed.)

Closed by commit rGcb6962124959: msdosfs: fix double unlock if the source file disappears (authored by trasz). · Explain WhyJan 31 2021, 9:37 PM
This revision was automatically updated to reflect the committed changes.
trasz added a commit: rGcb6962124959: msdosfs: fix double unlock if the source file disappears.
trasz added a commit: rGe681d7d702d6: msdosfs: fix double unlock if the source file disappears.Mar 2 2021, 6:43 PM

Revision Contents
Changeset List

PathSize
sys/
fs/
msdosfs/
1 line

Diff 79898

View Options

sys/fs/msdosfs/msdosfs_vnops.c

Loading...