Page MenuHomeFreeBSD

bug fix: iommu_gas_fini_domain()
ClosedPublic

Authored by br on Nov 16 2020, 11:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 6, 6:26 AM
Unknown Object (File)
Sat, Feb 22, 2:32 PM
Unknown Object (File)
Feb 21 2025, 9:48 AM
Unknown Object (File)
Feb 21 2025, 6:22 AM
Unknown Object (File)
Feb 20 2025, 2:15 PM
Unknown Object (File)
Feb 18 2025, 4:14 AM
Unknown Object (File)
Jan 26 2025, 12:24 PM
Unknown Object (File)
Dec 8 2024, 9:42 PM
Subscribers

Details

Summary

iommu_gas_init_domain() sets these two flags, so check them both in iommu_gas_fini_domain()

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

br requested review of this revision.Nov 16 2020, 11:37 AM
br created this revision.
sys/dev/iommu/iommu_gas.c
262 ↗(On Diff #79595)

Indent for continuation line should be +4 spaces, not tab. () are not needed.

Fix indentation

sys/dev/iommu/iommu_gas.c
262 ↗(On Diff #79595)

() are needed it seems:

sys/dev/iommu/iommu_gas.c:262:28: error: | has lower precedence than ==; == will be evaluated first [-Werror,-Wparentheses]

IOMMU_MAP_ENTRY_PLACE | IOMMU_MAP_ENTRY_UNMAPPED,
This revision is now accepted and ready to land.Nov 16 2020, 12:42 PM