Page MenuHomeFreeBSD
Differential D27235

bug fix: iommu_gas_fini_domain()
ClosedPublic
Actions

Authored by br on Nov 16 2020, 11:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 26, 12:24 PM
Unknown Object (File)
Dec 8 2024, 9:42 PM
Unknown Object (File)
Nov 16 2024, 4:45 PM
Unknown Object (File)
Oct 20 2024, 1:01 PM
Unknown Object (File)
Oct 20 2024, 1:01 PM
Unknown Object (File)
Oct 20 2024, 1:00 PM
Unknown Object (File)
Oct 20 2024, 1:00 PM
Unknown Object (File)
Oct 20 2024, 12:39 PM
View All 47 Files
Subscribers
imp

Details

Reviewers
kib
Commits
rS367726: Fix a bug in assertion: entry flags also includes IOMMU_MAP_ENTRY_UNMAPPED.
Summary

iommu_gas_init_domain() sets these two flags, so check them both in iommu_gas_fini_domain()

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

br requested review of this revision.Nov 16 2020, 11:37 AM
br created this revision.
kib added inline comments.Nov 16 2020, 12:28 PM
sys/dev/iommu/iommu_gas.c
262

Indent for continuation line should be +4 spaces, not tab. () are not needed.

br updated this revision to Diff 79599.Nov 16 2020, 12:34 PM

Fix indentation

sys/dev/iommu/iommu_gas.c
262

() are needed it seems:

sys/dev/iommu/iommu_gas.c:262:28: error: | has lower precedence than ==; == will be evaluated first [-Werror,-Wparentheses]

IOMMU_MAP_ENTRY_PLACE | IOMMU_MAP_ENTRY_UNMAPPED,
kib accepted this revision.Nov 16 2020, 12:42 PM
This revision is now accepted and ready to land.Nov 16 2020, 12:42 PM
Closed by commit rS367726: Fix a bug in assertion: entry flags also includes IOMMU_MAP_ENTRY_UNMAPPED. (authored by br). · Explain WhyNov 16 2020, 3:37 PM
This revision was automatically updated to reflect the committed changes.
br added a commit: rS367726: Fix a bug in assertion: entry flags also includes IOMMU_MAP_ENTRY_UNMAPPED..
Herald added a subscriber: imp. · View Herald TranscriptNov 16 2020, 3:37 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
iommu/
6 lines

Diff 79599

View Options

sys/dev/iommu/iommu_gas.c

Loading...