Page MenuHomeFreeBSD
Differential D27135

Questionable optimization for riscv cpu_fetch_syscall_args()
AbandonedPublic
Actions

Authored by trasz on Nov 7 2020, 6:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 21, 4:08 PM
Unknown Object (File)
Mon, Feb 10, 10:43 AM
Unknown Object (File)
Mon, Feb 10, 10:20 AM
Unknown Object (File)
Mon, Feb 10, 9:58 AM
Unknown Object (File)
Mon, Feb 10, 9:58 AM
Unknown Object (File)
Sat, Feb 8, 2:59 AM
Unknown Object (File)
Jan 20 2025, 10:55 PM
Unknown Object (File)
Jan 20 2025, 6:13 PM
View All 77 Files
Subscribers
imp
jhb

Details

Reviewers
None
Group Reviewers
riscv
Summary

XXX: stashed for later

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34685
Build 31752: arc lint + arc unit

Event Timeline

trasz created this revision.Nov 7 2020, 6:16 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 7 2020, 6:16 PM
trasz requested review of this revision.Nov 7 2020, 6:16 PM
Harbormaster completed remote builds in B34685: Diff 79304.Nov 7 2020, 6:17 PM
trasz planned changes to this revision.Nov 7 2020, 6:17 PM
trasz updated this revision to Diff 79305.Nov 7 2020, 6:17 PM

meh

Harbormaster completed remote builds in B34686: Diff 79305.Nov 7 2020, 6:17 PM
trasz updated this revision to Diff 79329.Nov 8 2020, 6:29 PM

Rework.

Harbormaster completed remote builds in B34696: Diff 79329.Nov 8 2020, 6:29 PM
trasz planned changes to this revision.Nov 8 2020, 6:31 PM
linimon added a reviewer: riscv.Jun 11 2021, 1:50 PM
jhb added a subscriber: jhb.Jun 11 2021, 11:19 PM
jhb added inline comments.
sys/riscv/riscv/trap.c
118–124

Why add this check for nosys? Checking sa_code should be sufficient?

120

This is now missing validation of sa->code and also doesn't update callp. Presumably this has broken any uses of syscall(2)?

trasz abandoned this revision.Mar 22 2024, 9:31 AM

Revision Contents
Changeset List

PathSize
sys/
mips/
include/
4 lines
mips/
7 lines
riscv/
riscv/
15 lines

Diff 79304

View Options

sys/mips/include/proc.h

Loading...
View Options

sys/mips/mips/trap.c

Loading...
View Options

sys/riscv/riscv/trap.c

Loading...