Differential D27007

Add set pipefail in most framework scripts.
ClosedPublic
Actions

Authored by mat on Oct 29 2020, 3:00 PM.

Tags

None

Referenced Files

	F150998142: D27007.id79066.diff
	Sun, Apr 5, 9:22 AM

	Unknown Object (File)
	Sat, Apr 4, 11:20 AM

	Unknown Object (File)
	Fri, Apr 3, 11:15 PM

	Unknown Object (File)
	Fri, Apr 3, 9:26 AM

	Unknown Object (File)
	Thu, Apr 2, 10:18 PM

	Unknown Object (File)
	Thu, Apr 2, 5:37 PM

	Unknown Object (File)
	Thu, Apr 2, 7:20 AM

	Unknown Object (File)
	Wed, Apr 1, 5:52 AM

Subscribers

None

Details

Reviewers

Group Reviewers

Commits

rP554894: Ignore grep return value.
rP554893: Add set pipefail in most framework scripts.

Summary

set pipefail changes the pipeline return status from being the return
status of the last command to the last non 0 exit status of any command
in the pipeline. This is needed to make sure all the commands in a
pipeline did actually return a non 0 status and not only the last one.

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 34563
Build 31657: arc lint + arc unit

Event Timeline

mat requested review of this revision.Oct 29 2020, 3:00 PM

mat created this revision.

Harbormaster completed remote builds in B34475: Diff 78903.Oct 29 2020, 3:00 PM

bapt accepted this revision.Oct 29 2020, 3:07 PM

This revision is now accepted and ready to land.Oct 29 2020, 3:07 PM

fixup! Add set pipefail in most framework scripts.

This revision now requires review to proceed.Nov 2 2020, 8:31 AM

Harbormaster completed remote builds in B34561: Diff 79064.Nov 2 2020, 8:31 AM

Ignore grep return value.

Harbormaster completed remote builds in B34563: Diff 79066.Nov 2 2020, 9:57 AM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 11 2020, 1:30 PM

Closed by commit rP554893: Add set pipefail in most framework scripts. (authored by mat). · Explain Why

This revision was automatically updated to reflect the committed changes.

mat added a commit: rP554893: Add set pipefail in most framework scripts..

mat added a commit: rP554894: Ignore grep return value..

Revision Contents
Changeset List

Path

Size

Mk/

Scripts/

check-desktop-entries.sh

1 line

check-stagedir.sh

1 line

check-vulnerable.sh

1 line

check_leftovers.sh

2 lines

1 line

create-manifest.sh

4 lines

depends-list.sh

1 line

desktop-categories.sh

1 line

dialog4ports.sh

1 line

1 line

1 line

1 line

do-users-groups.sh

1 line

2 lines

generate-symbols.sh

2 lines

install-desktop-entries.sh

1 line

1 line

plist_sub_sed_sort.sh

2 lines

2 lines

2 lines

rust-compat11-canary.sh

1 line

smart_makepatch.sh

2 lines

Diff 79066

Mk/Scripts/check-desktop-entries.sh

Loading...

Mk/Scripts/check-stagedir.sh

Loading...

Mk/Scripts/check-vulnerable.sh

Loading...

Mk/Scripts/check_leftovers.sh

Loading...

Mk/Scripts/checksum.sh

Loading...

Mk/Scripts/create-manifest.sh

Loading...

Mk/Scripts/depends-list.sh

Loading...

Mk/Scripts/desktop-categories.sh

Loading...

Mk/Scripts/dialog4ports.sh

Loading...

Mk/Scripts/do-depends.sh

Loading...

Mk/Scripts/do-fetch.sh

Loading...

Mk/Scripts/do-patch.sh

Loading...

Mk/Scripts/do-users-groups.sh

Loading...

Mk/Scripts/find-lib.sh

Loading...

Mk/Scripts/generate-symbols.sh

Loading...

Mk/Scripts/install-desktop-entries.sh

Loading...

Mk/Scripts/makesum.sh

Loading...

Mk/Scripts/plist_sub_sed_sort.sh

Loading...

Mk/Scripts/ports_env.sh

Loading...

Mk/Scripts/qa.sh

Loading...

Mk/Scripts/rust-compat11-canary.sh

Loading...

Mk/Scripts/smart_makepatch.sh

Loading...