audio/exhale: Update to 1.0.8
ClosedPublic
Actions

Authored by rhurlin on Nov 2 2020, 6:06 AM.

Details

Reviewers

arrowd
tcberner

Commits

rP553886: audio/exhale: Update to 1.0.8

Summary

From the changelog[1]:

minor quality improvements at low and high rates, some license text clarifications
exhaleApp: slightly improved loudness calculation for low and high sampling rates
exhaleLib: improved audio quality a bit for the lower and higher-rate CVBR modes
License: removed references to BSD text, clarified disclaimer and contributor text

[1] https://gitlab.com/ecodis/exhale/-/releases/v1.0.8

Could the reviewers please have a look at the new license part? Thanks.

Info about the change of the license can be found at the changelog[1] (last entry) and two other places[2][3].

[2] https://gitlab.com/ecodis/exhale#license
[3] https://gitlab.com/ecodis/exhale/-/blob/master/include/License.htm

Submitted by Daniel Engberg <daniel.engberg.lists@pyret.net> (maintainer) in PR 250748

Tested on Poudriere (amd64, i386). 'portlint -AC' is fine.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rhurlin created this revision.Nov 2 2020, 6:06 AM

Herald added a subscriber: mat. · View Herald TranscriptNov 2 2020, 6:06 AM

rhurlin requested review of this revision.Nov 2 2020, 6:06 AM

Harbormaster completed remote builds in B34560: Diff 79058.Nov 2 2020, 6:06 AM

rhurlin edited the summary of this revision. (Show Details)Nov 2 2020, 6:10 AM

Looks OK, but I didn't verify that LICENSE_PERMS actually match to what the license text say.

@rhurlin by the way, I think you don't really need to create a DIff revision only to reupload a patch from the Bugzilla PR. You can simply add me and Tobias to the CC field so we will approve these changes there.

This revision is now accepted and ready to land.Nov 2 2020, 6:22 AM

Closed by commit rP553886: audio/exhale: Update to 1.0.8 (authored by rhurlin). · Explain WhyNov 2 2020, 6:37 AM

This revision was automatically updated to reflect the committed changes.

rhurlin added a commit: rP553886: audio/exhale: Update to 1.0.8.

In D27051#603593, @arrowd wrote:

Looks OK, but I didn't verify that LICENSE_PERMS actually match to what the license text say.

I think, the maintainer Daniel Engberg, talks with the author in PM. It should be ok.

@rhurlin by the way, I think you don't really need to create a DIff revision only to reupload a patch from the Bugzilla PR. You can simply add me and Tobias to the CC field so we will approve these changes there.

Thanks for the offer. Creating a Diff from my local repo into Phabricator is intresting for me, because after your approval I am able to directly submit from this repo. (Is there another way to commit from Bugzilla I am not aware off?)

In D27051#603599, @rhurlin wrote:

In D27051#603593, @arrowd wrote:

Looks OK, but I didn't verify that LICENSE_PERMS actually match to what the license text say.

I think, the maintainer Daniel Engberg, talks with the author in PM. It should be ok.

@rhurlin by the way, I think you don't really need to create a DIff revision only to reupload a patch from the Bugzilla PR. You can simply add me and Tobias to the CC field so we will approve these changes there.

Thanks for the offer. Creating a Diff from my local repo into Phabricator is intresting for me, because after your approval I am able to directly submit from this repo. (Is there another way to commit from Bugzilla I am not aware off?)

Tools/scripts/getpatch gets you halfway to the commit :)

In D27051#603805, @tcberner wrote:

In D27051#603599, @rhurlin wrote:

Thanks for the offer. Creating a Diff from my local repo into Phabricator is intresting for me, because after your approval I am able to directly submit from this repo. (Is there another way to commit from Bugzilla I am not aware off?)

Tools/scripts/getpatch gets you halfway to the commit :)

Nice! Didn't hear about it before. Have you ever tried it?

In D27051#603882, @rhurlin wrote:

In D27051#603805, @tcberner wrote:

In D27051#603599, @rhurlin wrote:

Thanks for the offer. Creating a Diff from my local repo into Phabricator is intresting for me, because after your approval I am able to directly submit from this repo. (Is there another way to commit from Bugzilla I am not aware off?)

Tools/scripts/getpatch gets you halfway to the commit :)

Nice! Didn't hear about it before. Have you ever tried it?

That's how I download all the patches from bugzilla :)

In D27051#604116, @tcberner wrote:

In D27051#603882, @rhurlin wrote:

In D27051#603805, @tcberner wrote:

Tools/scripts/getpatch gets you halfway to the commit :)

Nice! Didn't hear about it before. Have you ever tried it?

That's how I download all the patches from bugzilla :)