Unignore signals when starting CloudABI processes.
ClosedPublic
Actions

Authored by ed on Aug 12 2015, 10:40 AM.

Details

Reviewers

Commits

rS286662: Unignore signals when starting CloudABI processes.

Summary

As CloudABI processes cannot adjust their signal handlers, we need to
make sure that we start up CloudABI processes with consistent signal
masks. Though the POSIx standard signal behavior is all right, we do
need to make sure that we ignore SIGPIPE, as it would otherwise be
hard to interact with pipes and sockets.

Extend execsigs() to iterate over ps_sigignore and call sigdflt() for
each of the ignored signals.

Test Plan

The tests for raise() now pass:
https://github.com/NuxiNL/cloudlibc/blob/master/src/libc/signal/raise_test.c#L55

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 59
Build 59: arc lint + arc unit

Event Timeline

ed updated this revision to Diff 7893.Aug 12 2015, 10:40 AM

ed retitled this revision from to Unignore signals when starting CloudABI processes..

ed updated this object.

ed edited the test plan for this revision. (Show Details)

ed added a reviewer: kib.

Herald added a subscriber: imp. · View Herald TranscriptAug 12 2015, 10:40 AM

kib added inline comments.Aug 12 2015, 11:16 AM

sys/kern/kern_sig.c
982	I doubt that any other ABI, besides your ABI, would ever need such hack. IMHO, you should keep the execsigs() interface as is, and test the SV_ABI_CLOUDABI flag instead of the parameter. Not to mention that the patch become much more compact.